SAAS-29539 - Auto-Discovery | AWS | Single | Terraform | Split volume scanning deployment

[noamshraga1]

The PR adds a condition to all the volume scanning resources that are created during the AWS single account onboarding process.
This condition depends on a new variable called volume_scanning_deployment, which defaults to true and can be set to false.

• If the variable does not exist or is set to true, onboarding will proceed as it does today — all volume scanning resources will be created as expected and volume scanning integration will be created in the Aqua console.

• If the variable is set to false, none of the volume scanning-related resources will be created.
  Note: When the variable is set to false, the regions variable is not relevant.

I also ran terraform fmt -recursive to format all the Terraform files in the directory.

Resolves: SAAS-29539

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[github-actions]

Terraform Validation Results:

Terraform Format Check ✅
Terraform Init ✅
Terraform Validate ✅
Terraform Test ✅
TFLint Check ✅

Pusher: @noamshraga1, Action: pull_request, Workflow: PR Checks

[semyonmor]

bugbot run

[github-actions]

Terraform Validation Results:

Terraform Format Check ✅
Terraform Init ✅
Terraform Validate ✅
Terraform Test ✅
TFLint Check ✅

Pusher: @noamshraga1, Action: pull_request, Workflow: PR Checks

[noamshraga1]

Bug: Conditional Resource Creation Breaks Dependency

The aws_lambda_invocation.generate_cspm_external_id_function has a depends_on dependency on aws_lambda_invocation.generate_volscan_external_id_function. The volscan invocation is now conditionally created using count = var.create_vol_scan_resource ? 1 : 0. When var.create_vol_scan_resource is false, the volscan invocation is not created, leading to a Terraform failure as it cannot resolve the dependency to a non-existent resource.

modules/single/modules/lambda/main.tf#L98-L99
Fix in Cursor

Was this report helpful? Give feedback by reacting with 👍 or 👎

[github-actions]

Terraform Validation Results:

Terraform Format Check ✅
Terraform Init ✅
Terraform Validate ✅
Terraform Test ✅
TFLint Check ✅

Pusher: @noamshraga1, Action: pull_request, Workflow: PR Checks

[github-actions]

Terraform Validation Results:

Terraform Format Check ✅
Terraform Init ✅
Terraform Validate ✅
Terraform Test ✅
TFLint Check ✅

Pusher: @noamshraga1, Action: pull_request, Workflow: PR Checks