Skip to content

SLK-100239 - Fix Race and Add Base CSPM#20

Merged
semyonmor merged 3 commits intomainfrom
idan-SLK-100239-fix-race-and-add-base-cspm_main
Sep 16, 2025
Merged

SLK-100239 - Fix Race and Add Base CSPM#20
semyonmor merged 3 commits intomainfrom
idan-SLK-100239-fix-race-and-add-base-cspm_main

Conversation

@idanch4
Copy link
Copy Markdown
Contributor

@idanch4 idanch4 commented Sep 4, 2025

AWS is the only provider where the CSPM call was made inside the provider itself - meaning the POST /keys call was initiated from the Terraform.

We’ve decided to change the logic in AWS to match the approach used in Azure and Google, where the call to CSPM is made from within the Discovery Manager.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.

❌ Idan Chernihov
❌ noamshraga1
❌ github-actions[bot]


Idan Chernihov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 4, 2025

Terraform Validation Results:

Terraform Format Check ✅
Terraform Init ✅
Terraform Validate ✅
Terraform Test ✅
TFLint Check ✅

Pusher: @idanch4, Action: pull_request, Workflow: PR Checks

@idanch4 idanch4 marked this pull request as ready for review September 16, 2025 12:00
@semyonmor semyonmor merged commit 5699472 into main Sep 16, 2025
4 of 5 checks passed
@semyonmor semyonmor deleted the idan-SLK-100239-fix-race-and-add-base-cspm_main branch September 16, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants