Skip to content

Conversation

@josedonizetti
Copy link
Collaborator

@josedonizetti josedonizetti commented Oct 31, 2025

Refactor flag sever:

  • new tests to validate all flags for CLI
  • new tests to validate all configurations
  • move from flags/server/* package, into flags/*, like all other flags

@codecov
Copy link

codecov bot commented Nov 4, 2025

Codecov Report

❌ Patch coverage is 71.25749% with 48 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@584c3eb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/cmd/flags/server.go 87.70% 12 Missing and 3 partials ⚠️
pkg/server/http/server.go 17.64% 14 Missing ⚠️
pkg/server/grpc/server.go 0.00% 9 Missing ⚠️
pkg/cmd/cobra/cobra.go 0.00% 4 Missing ⚠️
cmd/tracee/cmd/root.go 0.00% 3 Missing ⚠️
cmd/tracee-rules/main.go 0.00% 1 Missing ⚠️
pkg/cmd/tracee.go 0.00% 1 Missing ⚠️
pkg/cmd/urfave/urfave.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5004   +/-   ##
=======================================
  Coverage        ?   29.77%           
=======================================
  Files           ?      234           
  Lines           ?    26216           
  Branches        ?        0           
=======================================
  Hits            ?     7807           
  Misses          ?    17875           
  Partials        ?      534           
Flag Coverage Δ
unit 29.77% <71.25%> (?)
Files with missing lines Coverage Δ
cmd/tracee-ebpf/main.go 0.00% <ø> (ø)
pkg/cmd/cobra/config.go 89.38% <100.00%> (ø)
cmd/tracee-rules/main.go 15.44% <0.00%> (ø)
pkg/cmd/tracee.go 0.00% <0.00%> (ø)
pkg/cmd/urfave/urfave.go 0.00% <0.00%> (ø)
cmd/tracee/cmd/root.go 0.00% <0.00%> (ø)
pkg/cmd/cobra/cobra.go 0.00% <0.00%> (ø)
pkg/server/grpc/server.go 55.93% <0.00%> (ø)
pkg/server/http/server.go 34.11% <17.64%> (ø)
pkg/cmd/flags/server.go 87.70% <87.70%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@josedonizetti josedonizetti marked this pull request as ready for review November 7, 2025 20:47
@josedonizetti josedonizetti changed the title flag(server): new flag format flag(server): refactor flag Nov 7, 2025
Copy link
Collaborator

@yanivagman yanivagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants