Skip to content

Conversation

@yanivagman
Copy link
Collaborator

This reverts commit 4627bdb to test if it caused the recent errors in the integration tests

Copilot AI review requested due to automatic review settings November 24, 2025 07:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts a previously merged commit that added the GetAllEventDependentsOfProbe functionality. The revert is being performed to investigate whether this feature introduced issues in the integration test suite. The changes remove both the implementation and comprehensive test coverage that was added in the original commit.

Key Changes

  • Removed GetAllEventDependentsOfProbe method and its helper function collectAllEventDependents from the dependency manager
  • Removed the corresponding test suite covering error cases, direct/transitive dependencies, and complex dependency patterns
  • Removed the unused probes package import that was only needed for the reverted functionality

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/events/dependencies/manager_events.go Removed the GetAllEventDependentsOfProbe implementation and helper methods, along with unused import
pkg/events/dependencies/manager_test.go Removed comprehensive test suite for GetAllEventDependentsOfProbe covering 17 test cases

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 30.25%. Comparing base (034cbab) to head (1aaca5a).
⚠️ Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5075      +/-   ##
==========================================
+ Coverage   29.72%   30.25%   +0.53%     
==========================================
  Files         234      232       -2     
  Lines       26186    25889     -297     
==========================================
+ Hits         7785     7834      +49     
+ Misses      17864    17519     -345     
+ Partials      537      536       -1     
Flag Coverage Δ
unit 30.25% <ø> (+0.53%) ⬆️
Files with missing lines Coverage Δ
pkg/events/dependencies/manager_events.go 83.33% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yanivagman yanivagman closed this Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant