Merged
Conversation
Add a list of default skip directories. These directories are overridden at a workspace level through the standard vscode settings. The skipdirs can be added to or removed from, if there are any in the list when the scan runs, it will add them using the --skip-dirs flag for Trivy or the Aqua plugin
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring directories to skip during Trivy scans through a new skipDirList configuration option.
- Implements a new
SkipDirOptionclass to handle the--skip-dirsTrivy command flag - Adds a
trivy.skipDirListconfiguration setting with sensible defaults (e.g.,node_modules,.git, etc.) - Integrates the skip directory option into the Trivy command builder
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/command/options.ts | Implements the SkipDirOption class to apply the --skip-dirs flag with platform-specific quoting behavior |
| src/command/command.ts | Integrates SkipDirOption into the default Trivy command options list |
| package.json | Adds trivy.skipDirList configuration with default directories to skip and bumps version to 1.8.8 |
| CHANGELOG.md | Documents the new skip directories feature in version 1.8.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a list of default skip directories. These directories are overridden
at a workspace level through the standard vscode settings.
The skipdirs can be added to or removed from, if there are any in the
list when the scan runs, it will add them using the --skip-dirs flag for
Trivy or the Aqua plugin