Skip to content

Comments

feat: add CA support for proxy in aqua plugin#141

Merged
owenrumney merged 1 commit intomasterfrom
feat/add-proxy-support
Nov 14, 2025
Merged

feat: add CA support for proxy in aqua plugin#141
owenrumney merged 1 commit intomasterfrom
feat/add-proxy-support

Conversation

@owenrumney
Copy link
Contributor

@owenrumney owenrumney commented Nov 6, 2025

The commercial trivy plugin supports providing a proxy and a CA
certificate. This is now configurable through the "Configure Aqua
Platform" webview.

When the proxy has a value it will be set, same with the CA Cert.

Closes #142

@owenrumney owenrumney self-assigned this Nov 6, 2025
@owenrumney owenrumney requested a review from Copilot November 6, 2025 17:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for configuring a custom proxy server and CA certificate for Aqua Platform communications in the Trivy VS Code extension.

  • Adds UI fields for proxy server and CA certificate path configuration
  • Implements a file browser dialog for selecting CA certificates
  • Sets corresponding HTTP_PROXY, HTTPS_PROXY, and CA_CERT environment variables

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
src/commercial/setup.ts Adds proxy and CA cert configuration UI fields, file browser dialog for certificate selection, and configuration persistence logic
src/commercial/env.ts Sets HTTP_PROXY, HTTPS_PROXY, and CA_CERT environment variables from configuration
package.json Defines new configuration properties for proxy server and CA certificate path, bumps version to 1.8.9
CHANGELOG.md Documents the new proxy and CA certificate support feature
.gitignore Adds cert.pem and key.pem to ignored files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@owenrumney owenrumney force-pushed the feat/add-proxy-support branch from 7aaa301 to 47d6b43 Compare November 6, 2025 17:33
@aquasecurity aquasecurity deleted a comment from Copilot AI Nov 6, 2025
@aquasecurity aquasecurity deleted a comment from Copilot AI Nov 6, 2025
@aquasecurity aquasecurity deleted a comment from Copilot AI Nov 6, 2025
@aquasecurity aquasecurity deleted a comment from Copilot AI Nov 6, 2025
@aquasecurity aquasecurity deleted a comment from Copilot AI Nov 6, 2025
The commercial trivy plugin supports providing a proxy and a CA
certificate. This is now configurable through the "Configure Aqua
Platform" webview.

When the proxy has a value it will be set, same with the CA Cert.
@owenrumney owenrumney force-pushed the feat/add-proxy-support branch from 47d6b43 to 00d247c Compare November 10, 2025 15:02
@owenrumney owenrumney merged commit 44d479c into master Nov 14, 2025
3 checks passed
@owenrumney owenrumney deleted the feat/add-proxy-support branch November 14, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add support for setting proxy and CA Cert for the aqua plugin integration

1 participant