feat: add CA support for proxy in aqua plugin#141
Merged
owenrumney merged 1 commit intomasterfrom Nov 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring a custom proxy server and CA certificate for Aqua Platform communications in the Trivy VS Code extension.
- Adds UI fields for proxy server and CA certificate path configuration
- Implements a file browser dialog for selecting CA certificates
- Sets corresponding HTTP_PROXY, HTTPS_PROXY, and CA_CERT environment variables
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/commercial/setup.ts | Adds proxy and CA cert configuration UI fields, file browser dialog for certificate selection, and configuration persistence logic |
| src/commercial/env.ts | Sets HTTP_PROXY, HTTPS_PROXY, and CA_CERT environment variables from configuration |
| package.json | Defines new configuration properties for proxy server and CA certificate path, bumps version to 1.8.9 |
| CHANGELOG.md | Documents the new proxy and CA certificate support feature |
| .gitignore | Adds cert.pem and key.pem to ignored files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7aaa301 to
47d6b43
Compare
The commercial trivy plugin supports providing a proxy and a CA certificate. This is now configurable through the "Configure Aqua Platform" webview. When the proxy has a value it will be set, same with the CA Cert.
47d6b43 to
00d247c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commercial trivy plugin supports providing a proxy and a CA
certificate. This is now configurable through the "Configure Aqua
Platform" webview.
When the proxy has a value it will be set, same with the CA Cert.
Closes #142