ci: add zizmor to scan GitHub Actions workflows#10322
Draft
DmitriyLewen wants to merge 5 commits intoaquasecurity:mainfrom
Draft
ci: add zizmor to scan GitHub Actions workflows#10322DmitriyLewen wants to merge 5 commits intoaquasecurity:mainfrom
DmitriyLewen wants to merge 5 commits intoaquasecurity:mainfrom
Conversation
Fix all 13 error-level findings reported by zizmor across .github/: - setup-go/action.yaml: fix template-injection by moving inputs.go-version-file to env var - trivy-triage/action.yaml: pin actions/github-script to SHA and fix template-injection by moving inputs.discussion_num to env var - mkdocs-latest.yaml: fix 3 template-injection findings (github.ref, inputs.version, github.ref_name) by using env vars and built-in GITHUB_* variables - release-please.yaml: fix 2 template-injection findings by moving inputs.version and github.ref_name to env vars - release.yaml: fix 3 template-injection findings (github.ref_name in workflow triggers) and suppress cache-poisoning false positive - reusable-release.yaml: suppress cache-poisoning false positive - auto-ready-for-review.yaml: suppress dangerous-triggers and fix template-injection by moving steps.pr-context.outputs.number to env var
DmitriyLewen
commented
Mar 4, 2026
| interval: weekly | ||
| cooldown: | ||
| default-days: 3 | ||
| default-days: 7 |
Contributor
Author
There was a problem hiding this comment.
zizmor recommends a 7-day delay here.
Let me know if there's a specific reason you went with 3 days.
refs:
Member
There was a problem hiding this comment.
I don't recall why we have 3, I guess we can go 7.
Contributor
There was a problem hiding this comment.
I think so too. There is no advantage to quickly updating dependencies.
simar7
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add zizmor — a static analysis tool for GitHub Actions workflows — as a CI check that runs on every PR touching
.github/.Changes
zizmorjob intest.yamlscoped to.github/setup-go,trivy-triage,mkdocs-latest,release-please,release,auto-ready-for-review— replaced${{ expr }}inrun:blocks with environment variablestrivy-triage— pinnedactions/github-scriptto SHAreleaseandreusable-release— suppressed with inline ignore comments (legitimate pattern: cache is keyed bygithub.sha)auto-ready-for-review— suppressed with inline ignore comment (intentionalworkflow_runuse)Checklist