perf(plugin): optimize directory traversal by replacing filepath.Walk with filepath.WalkDir#10325
Open
ankit98040 wants to merge 1 commit intoaquasecurity:mainfrom
Open
perf(plugin): optimize directory traversal by replacing filepath.Walk with filepath.WalkDir#10325ankit98040 wants to merge 1 commit intoaquasecurity:mainfrom
ankit98040 wants to merge 1 commit intoaquasecurity:mainfrom
Conversation
… with filepath.WalkDir Prior to Go 1.16, `filepath.Walk` invoked `os.Lstat` on every visited file or directory to retrieve a heavy `fs.FileInfo` object, causing a significant performance bottleneck due to excessive system calls. This commit replaces `filepath.Walk` with the more performant `filepath.WalkDir` API in the `pkg/module` package. The newer API passes an `fs.DirEntry` instead, which utilizes cached directory entry information provided by modern operating systems during the initial directory read. This optimization minimizes unnecessary `lstat` syscalls over large directory structures when loading WebAssembly modules, significantly improving filesystem traversal speed and reducing CPU overhead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
perf(plugin): optimize directory traversal with filepath.WalkDir
Prior to Go 1.16,
filepath.Walkinvokedos.Lstaton every visited file or directory to retrieve a heavyfs.FileInfoobject, causing a significant performance bottleneck due to excessive system calls.This commit replaces
filepath.Walkwith the more performantfilepath.WalkDirAPI in thepkg/modulepackage. The newer API passes anfs.DirEntryinstead, which utilizes cached directory entry information provided by modern operating systems during the initial directory read.This optimization minimizes unnecessary
lstatsyscalls over large directory structures when loading WebAssembly modules, significantly improving filesystem traversal speed and reducing CPU overhead.Checklist