refactor(misconf): propagate metadata through CF property chain#10759
Draft
nikpivkin wants to merge 2 commits into
Draft
refactor(misconf): propagate metadata through CF property chain#10759nikpivkin wants to merge 2 commits into
nikpivkin wants to merge 2 commits into
Conversation
fdce06d to
cd50886
Compare
cd50886 to
3bb7037
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
Get*Propertymethods onResourceused resource-level metadata as fallback when a key was absent, somisconfiguration findings would point to the resource root instead of the actual location in the template.
With metadata propagation through the chain, findings now point to the closest existing ancestor, which is semantically
more accurate.
The old behavior also masked a bug where incorrect property paths silently resolved by skipping
missing components — e.g.
ResultConfiguration.EncryptionConfiguration.EncryptionOptionwould return the value ofResultConfiguration.EncryptionOptionifEncryptionConfigurationdid not exist.GetPropertyonResourceandPropertynow propagates parent metadata to the returned value when a key is absentAs*Valuemethods use the property's own metadata instead of requiring it as a parameterChecklist