Skip to content

docs: clarify debug logs when version check or telemetry is disabled - #10984

Open
DmitriyLewen wants to merge 1 commit into
aquasecurity:mainfrom
DmitriyLewen:fix/version-check-telemetry-logs
Open

docs: clarify debug logs when version check or telemetry is disabled#10984
DmitriyLewen wants to merge 1 commit into
aquasecurity:mainfrom
DmitriyLewen:fix/version-check-telemetry-logs

Conversation

@DmitriyLewen

Copy link
Copy Markdown
Contributor

Description

When --skip-version-check is used without --disable-telemetry, the request to check.trivy.dev is still sent to deliver anonymous telemetry, but the debug log misleadingly says Running version check.
This confused a user in discussion #10971 into thinking the flag does not work.

This PR makes the debug log messages accurately reflect the actual flag combination:

Flags Before After
both Skipping update check and metric ping Version check and telemetry are disabled, skipping request
--skip-version-check only Running version check Version check is disabled, sending anonymous telemetry only
--disable-telemetry only Running version check Telemetry is disabled, running version check only
none Running version check Running version check and sending anonymous telemetry
on success with --skip-version-check Version check completed latest_version=... Telemetry sent
on success otherwise Version check completed latest_version=... Version check completed latest_version=... (unchanged)

The docs are also updated: the Check for updates and Telemetry sections now cross-reference each other and note that both features share a single request to check.trivy.dev, linking to the Check updates service section of the air-gap guide.

Before

$ trivy config -d --skip-version-check .
...
DEBUG  [notification] Running version check

After

$ trivy config -d --skip-version-check .
...
DEBUG  [notification] Version check is disabled, sending anonymous telemetry only

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen changed the title fix(notification): clarify debug logs when version check or telemetry is disabled docs: clarify debug logs when version check or telemetry is disabled Jul 22, 2026
@DmitriyLewen
DmitriyLewen requested a review from nikpivkin July 22, 2026 12:20
@DmitriyLewen
DmitriyLewen marked this pull request as ready for review July 22, 2026 12:20
@DmitriyLewen
DmitriyLewen requested a review from knqyf263 as a code owner July 22, 2026 12:20

@mustafakapasi mustafakapasi left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants