Open
Conversation
This was referenced Sep 12, 2025
rootio/rootio.go
Outdated
Comment on lines
+18
to
+19
| osFeedPath = "external/os_feed" // OS packages feed | ||
| appFeedPath = "external/app_feed" // Language/app packages feed |
Contributor
There was a problem hiding this comment.
How can I download the new files for testing?
Only https://api.root.io/external/cve_feed is available.
Contributor
Author
There was a problem hiding this comment.
Youre right. Its being developed at the same time. I want to validate the PRs are accepted and I'll merge it on our side before merging the Trivy ones
Contributor
|
And can you add the PR description, please? |
- Replace []feedInfo with map[string]string (endpoint → subdir). - Introduce feedFileName = "cve_feed.json" for consistency. - Change fetchAndSaveFeed to use (apiPath, subdir) parameters. - Always create target dir via os.MkdirAll(rootio/). - Minor cleanups: consistent err assignment and options loop.
Contributor
|
hello @chait-slim Can you re-check? |
Contributor
Author
Hi, I've rechecked. From my end its approved. I've updated the tests with the real use cases of how versioning will look like in the app feed. Tomorrow morning the new API will be running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for Root.io application-level vulnerability feeds to vuln-list-update, extending the existing OS-level vulnerability tracking with language/framework-specific vulnerability data.
Changes Introduced
Both feeds use the same JSON structure:
Directory Structure
After running the updater, the vulnerability data is organized as:
Testing