fix(suse): save CVSSScoreSets as array#401
Open
DmitriyLewen wants to merge 2 commits intoaquasecurity:mainfrom
Open
fix(suse): save CVSSScoreSets as array#401DmitriyLewen wants to merge 2 commits intoaquasecurity:mainfrom
DmitriyLewen wants to merge 2 commits intoaquasecurity:mainfrom
Conversation
- add test case with multiple CVSSScoreSets - remove empty CVSSScoreSets fields
Collaborator
|
Won't it cause the same problem as #398 since it changes the type of the existing field? |
Contributor
Author
|
yeah, I also thought about this. |
Contributor
Author
|
@knqyf263 Premium team approved these changes. |
Collaborator
|
However, it is used in trivy-db. And if they are unable to update trivy-db to the latest commit, wouldn’t parsing still fail? |
Contributor
Author
|
Nice catch! |
Contributor
|
can we add a new field with updated type? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change CVSSScoreSets field from single object to array in SUSE CVRF parser to support multiple CVSS scores per vulnerability (e.g., NVD score and SUSE score)
e.g. https://ftp.suse.com/pub/projects/security/cvrf/cvrf-suse-su-2016%3A0304-1.xml
Test plan