feat(rootio): migrate to OSV zip format, remove legacy CVEFeed package#438
Open
chait-slim wants to merge 2 commits into
Open
feat(rootio): migrate to OSV zip format, remove legacy CVEFeed package#438chait-slim wants to merge 2 commits into
chait-slim wants to merge 2 commits into
Conversation
chait-slim
force-pushed
the
feat/rootio-osv-migration
branch
2 times, most recently
from
af3aa84 to
c0c686a
Compare
chait-slim
force-pushed
the
feat/rootio-osv-migration
branch
from
c0c686a to
eda3c63
Compare
| case "rootio": | ||
| ru := rootio.NewUpdater() | ||
| if err := ru.Update(); err != nil { | ||
| rootOSV := osv.NewDatabase( |
Contributor
There was a problem hiding this comment.
Can you create package?
like osvdev and seal?
and add tests
Contributor
|
BTW - i don't see severity for OSV feed. |
dedicated rootio package that mirrors the osvdev and seal pattern (defaultEcosystems, functional options, NewDatabase constructor). Add httptest-backed table tests with happy/sad paths and golden fixtures. Signed-off-by: Chai Tadmor <chai.tadmor@root.io>
Contributor
Author
Good point. Updating the API |
Contributor
Author
|
@DmitriyLewen would really appreciate your review on these PRs |
DmitriyLewen
reviewed
May 4, 2026
DmitriyLewen
left a comment
DmitriyLewen
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
left small comments.
Also I think we can change workflow message:
diff --git a/.github/workflows/update.yml b/.github/workflows/update.yml
index cc1883a..25d060e 100644
--- a/.github/workflows/update.yml
+++ b/.github/workflows/update.yml
@@ -121,7 +121,7 @@ jobs:
- if: always()
name: Root CVE Tracker
- run: ./scripts/update.sh rootio "Root CVE Feed Tracker"
+ run: ./scripts/update.sh rootio "Root.io OSV Tracker"
- name: Microsoft Teams Notification
uses: Skitionek/notify-microsoft-teams@e7a2493ac87dad8aa7a62f079f295e54ff511d88
Contributor
There was a problem hiding this comment.
Can you create a test archive with real files?
Your real archive contains rootio-curl (instead of curl) — this is confusing.
|
|
||
| func WithVulnListDir(v string) option { | ||
| return func(c *Updater) { c.vulnListDir = v } | ||
| var defaultEcosystems = map[string]osv.Ecosystem{ |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| var defaultEcosystems = map[string]osv.Ecosystem{ | |
| // Root.io uses a single archive for all ecosystems, so we use a single ecosystem | |
| // and an empty dir (the `rootio` dir is added via options.dir). | |
| var defaultEcosystems = map[string]osv.Ecosystem{ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.