Admin Plugin

Audit

v1.2.0

Halborn: audit report

• Commit ID: 546cfa243a5d0726d75158db646573ca2237f570
• Started: 2024-11-18
• Finished: 2025-02-13

ABI and artifacts

Check out the artifacts folder to get the deployed addresses and the contract ABI's.

Project

The root folder of the repo includes two subfolders:

.
├── packages/artifacts
│ ├── src
│ ├── prepare-abi.sh
│ ├── README.md
│ ├── ...
| └── package.json
|
├── packages/contracts
│ ├── src
│ ├── deploy
│ ├── test
│ ├── utils
│ ├── ...
│ └── package.json
│
├── ...
└── package.json

The root-level package.json file contains global dev-dependencies for formatting and linting. After installing the dependencies with

yarn --ignore-scripts

you can run the associated formatting and linting commands.

Formatting

yarn prettier:check

all .sol, .js, .ts, .json, and .yml files will be format-checked according to the specifications in .prettierrc file.With

yarn prettier:write

the formatting is applied.

Linting

With

yarn lint

.sol, .js, and .ts files in the subfolders are analyzed with solhint and eslint, respectively.

Setting Environment Variables

To be able to work on the contracts, make sure that you have created an .env file from the .env.example file and put in the API keys for

• Alchemy that we use as the web3 provider
• the block explorer that you want to use depending on the networks that you want to deploy to

Before deploying, you MUST also change the default hardhat private key (PRIVATE_KEY="0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80").

Contracts

This package is located in packages/contracts.

Install Dependencies

yarn --ignore-scripts

Building

To build the contracts on EVM based networks:

yarn build

On Zksync:

yarn build:zksync

Testing

To test your contracts on EVM based networks, run

yarn test

On Zksync:

yarn test:zksync

Linting

Lint the Solidity and TypeScript code all together with

yarn lint

or separately with

yarn lint:sol

and

yarn lint:ts

Coverage

Generate the code coverage report with

yarn coverage

Gas Report

See the gas usage per test and average gas per method call with

REPORT_GAS=true yarn test

you can permanently enable the gas reporting by putting the REPORT_GAS=true into the .env file.

Deployment

The deploy scripts provided inside ./packages/contracts/deploy take care of

1. Creating an on-chain Plugin Repository for you through Aragon's factories with an unique ENS name.
2. Publishing the first version of your Plugin and associated PluginSetup contract in your repo from step 1.
3. Upgrade your plugin repository to the latest Aragon OSx protocol version.

Finally, it verifies all contracts on the block explorer of the chosen network.

You don't need to make changes to the deploy script. You only have to update the entries in packages/contracts/plugin-settings.ts as explained in the template usage guide.

Creating a Plugin Repository & Publishing Your Plugin

Deploy the contracts to the local Hardhat Network (being forked from the network specified in NETWORK_NAME in your .env file ) with

yarn deploy --tags CreateRepo,NewVersion

This will create a plugin repo and publish the first version (v1.1) of your plugin. By adding the tag TransferOwnershipToManagmentDao, the ROOT_PERMISSION_ID, MAINTAINER_PERMISSION_ID, and UPGRADE_REPO_PERMISSION_ID are granted to the management DAO and revoked from the deployer. You can do this directly

yarn deploy --tags CreateRepo,NewVersion,TransferOwnershipToManagmentDao

or at a later point by executing

yarn deploy --tags TransferOwnershipToManagmentDao

To deploy the contracts to a production network use the --network option, for example

yarn deploy --network sepolia --tags CreateRepo,NewVersion,TransferOwnershipToManagmentDao,Verification

This will create a plugin repo, publish the first version (v1.1) of your plugin, transfer permissions to the management DAO, and lastly verfiy the contracts on sepolia.

If you want to deploy a new version of your plugin afterwards (e.g., 1.2), simply change the VERSION entry in the packages/contracts/plugin-settings.ts file and use

yarn deploy --network sepolia --tags NewVersion,Verification

Note, that if the deploying account doesn't own the repo anymore, this will create a createVersionProposalData-sepolia.json containing the data for a management DAO signer to create a proposal publishing a new version.

Note, that if you include the CreateRepo tag after you've created your plugin repo already, this part of the script will be skipped.

Upgrading Your Plugin Repository

Upgrade your plugin repo on the local Hardhat Network (being forked from the network specified in NETWORK_NAME in your .env file ) with

yarn deploy --tags UpgradeRepo

Upgrade your plugin repo on sepolia with

yarn deploy --network sepolia --tags UpgradeRepo

This will upgrade your plugin repo to the latest Aragon OSx protocol version implementation, which might include new features and security updates. For this to work, make sure that you are using the latest version of this repository in your fork.

Note, that if the deploying account doesn't own the repo anymore, this will create a upgradeRepoProposalData-sepolia.json containing the data for a management DAO signer to create a proposal upgrading the repo.

If you want to run deployments against zksync, you can use:

yarn deploy:zksync --network zksyncSepolia --tags ...
yarn deploy:zksync --network zksyncMainnet --tags ...

License

This project is licensed under AGPL-3.0-or-later.