-
Notifications
You must be signed in to change notification settings - Fork 1
Sandbox: drpc and subdao #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Sandbox: drpc and subdao #1002
Conversation
β¦ and parentDao fields
β¦ter readability and consistency
β¦s and improve pagination logic
β¦le DAO addresses
β¦d improve session management
β¦child relationship handling
β¦nfo and improve clarity
β¦rent and sub DAOs
β¦metrics collection
β¦ feat/sudbao-drpc
β¦ggregation logic
β¦full test execution
β¦e test coverage
β¦clarity and functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces comprehensive support for capital flow policy plugins (router/claimer) and sub-DAO hierarchical relationships. It adds new V3 API endpoints that return DAOs without plugins (plugins fetched separately), implements bidirectional parent-child DAO linking via permissions, and includes extensive test coverage for the new functionality.
Changes:
- Added policy plugin support with router/claimer interface types, source/model contracts, and factory event tracking
- Implemented sub-DAO functionality with parent-child relationships, hierarchical queries, and aggregated metrics
- Created V3 API endpoints for DAOs without embedded plugins, policy endpoints, and enhanced plugin/asset/transaction/proposal queries with sub-DAO support
Reviewed changes
Copilot reviewed 97 out of 97 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/unit/services/aragon-plugins/logPolicy.spec.ts | Unit tests for LogPolicy service covering source/model/plugin sync |
| test/unit/services/aragon-plugins/index.spec.ts | Tests for router/claimer plugin queue processing |
| test/unit/services/aragon-api/routers/v3/dao.spec.ts | Tests for new V3 DAO endpoints without plugins |
| test/unit/services/aragon-api/routers/v2/*.spec.ts | Tests for updated V2 routes with onlyParent/subDAO support |
| test/unit/services/aragon-api/controllers/*.spec.ts | Tests for controllers with sub-DAO hierarchy queries |
| test/unit/handlers/*.spec.ts | Tests for policy, permission, and plugin setting handlers |
| test/unit/helpers/*.spec.ts | Tests for policy detection, helper utilities, and config indexer |
| test/unit/models/schema/*.spec.ts | Tests for DAO/permission models with sub-DAO support |
| test/unit/modules/*.spec.ts | Tests for module updates (ipfs, proxyProvider) |
| test/unit-dep/*.spec.ts | Integration tests for sub-DAO linking and capital flow |
| src/services/aragon-plugins/logPolicy.ts | New service for syncing policy plugin events |
| src/services/aragon-api/routers/v3/* | New V3 API without plugins in DAO response |
| src/services/aragon-api/routers/v2/policy.ts | New policy router for fetching policies by DAO |
| src/services/aragon-api/controllers/*.ts | Updated controllers with sub-DAO hierarchy support |
| src/types/*.ts | New types for policies, permissions, plugin interfaces |
| src/models/schema/*.ts | Model updates for sub-DAO queries and aggregations |
| src/helpers/web3Utils.ts | Updated metadata parsing for policyKey |
| src/modules/ipfs.ts | Simplified metadata fetching (removed redundant parsing) |
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
π Summary
Explain the purpose of these changes and what problem they solve.
Task: APP-0000
π What Changed
β Checklist
π Code Review
π§ͺ Testing
π Security