Skip to content

feat(APP-4405): Implement SmartContractFunctionDataListItem module component - #530

Merged
cgero-eth merged 16 commits into
mainfrom
feat/APP-4405
Jul 17, 2025
Merged

feat(APP-4405): Implement SmartContractFunctionDataListItem module component#530
cgero-eth merged 16 commits into
mainfrom
feat/APP-4405

Conversation

@shan8851

@shan8851 shan8851 commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

  • Implement SmartContractFunctionDataListItem module component
  • Use SmartContractFunctionDataListItem component in the ProposalActionsItem component

Task: APP-4405

Type of change

  • New feature (non-breaking change which adds functionality)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

@arabot-1

arabot-1 commented Jul 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment: View Here

@cgero-eth cgero-eth self-assigned this Jul 16, 2025
cgero-eth
cgero-eth reviewed Jul 16, 2025
View reviewed changes
Comment thread src/modules/components/smartContract/smartContractFunctionDataListItem/index.ts Outdated
Comment thread ...Item/smartContractFunctionDataListItemSkeleton/smartContractFunctionDataListItemSkeleton.tsx
Comment thread ...em/smartContractFunctionDataListItemStructure/smartContractFunctionDataListItemStructure.tsx Outdated
Comment thread src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx
Comment thread ...ContractFunctionDataListItemStructure/smartContractFunctionDataListItemStructure.stories.tsx Outdated
Comment thread src/modules/components/proposal/proposalActions/proposalActionsItem/proposalActionsItem.tsx Outdated
@shan8851
shan8851 requested a review from cgero-eth July 16, 2025 11:21
cgero-eth
cgero-eth reviewed Jul 17, 2025
View reviewed changes
Comment thread ...ontract/smartContractFunctionDataListItem/smartContractFunctionDataListItemSkeleton/index.ts Outdated
Comment thread ...ponents/proposal/proposalActions/proposalActionsItemSkeleton/proposalActionsItemSkeleton.tsx Outdated
@shan8851
chore: remove content component, add as child prop to correctly style…
1d94c99 
… and handle accesibility props for skeleton component
@shan8851
shan8851 requested a review from cgero-eth July 17, 2025 09:46
cgero-eth
cgero-eth approved these changes Jul 17, 2025
View reviewed changes

@cgero-eth cgero-eth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@cgero-eth
cgero-eth merged commit af2c2d5 into main Jul 17, 2025
5 checks passed
@cgero-eth
cgero-eth deleted the feat/APP-4405 branch July 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@milosh86 milosh86 Awaiting requested review from milosh86
@thekidnamedkd thekidnamedkd Awaiting requested review from thekidnamedkd
1 more reviewer
@cgero-eth cgero-eth cgero-eth approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cgero-eth cgero-eth

Labels

preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shan8851 @arabot-1 @cgero-eth