Skip to content

fix: Reduce text size of the descriptions on the RadioCard and CheckboxCard components - #537

Merged
cgero-eth merged 10 commits into
mainfrom
smaller-descriptions-cards
Jul 25, 2025
Merged

fix: Reduce text size of the descriptions on the RadioCard and CheckboxCard components#537
cgero-eth merged 10 commits into
mainfrom
smaller-descriptions-cards

Conversation

@evanaronson

@evanaronson evanaronson commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Description

We've always struggled in the governance designer to have enough space to add descriptions to components. Giving a little more space will help. Selim approved the design change and will do in figma.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
@arabot-1

arabot-1 commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment: View Here

evanaronson and others added 2 commits July 23, 2025 13:25
Signed-off-by: Evan Aronson <93671071+evanaronson@users.noreply.github.com>
@evanaronson evanaronson changed the title WIP: Smaller descriptions on radiocard and checkboxcard fix: Smaller descriptions on radiocard and checkboxcard Jul 23, 2025
Comment thread .changeset/big-texts-hurt.md Outdated
@cgero-eth cgero-eth changed the title fix: Smaller descriptions on radiocard and checkboxcard fix: Reduce text size of the descriptions on the RadioCard and CheckboxCard components Jul 25, 2025
@cgero-eth cgero-eth self-assigned this Jul 25, 2025

@thekidnamedkd thekidnamedkd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one doubt, but the pattern is duplicated so if we disagree then I am fine to live with it.

Comment thread src/core/components/forms/radioCard/radioCard.tsx
@cgero-eth
cgero-eth merged commit 44ec981 into main Jul 25, 2025
8 checks passed
@cgero-eth
cgero-eth deleted the smaller-descriptions-cards branch July 25, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants