Skip to content

feat(APP-4058): Implement ActionSimulation component - #572

Merged
cgero-eth merged 32 commits into
mainfrom
APP-4058-tenderly
Aug 29, 2025
Merged

feat(APP-4058): Implement ActionSimulation component#572
cgero-eth merged 32 commits into
mainfrom
APP-4058-tenderly

Conversation

@milosh86

@milosh86 milosh86 commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

Description

  • Implement ActionSimulation component.
  • Update dropdown component to accept the variant from and to allow rendering items as submit buttons.

Task: APP-4058

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Developer Checklist:

  • Manually smoke tested the functionality locally
  • Confirmed there are no new warnings or errors in the browser console
  • Made the corresponding changes to the documentation
  • Added tests that prove my fix is effective or that my feature works
  • (For User Stories only) Double-checked that all Acceptance Criteria are satisified
  • Confirmed there are no new warnings on automated tests
  • Selected the correct base branch
  • Commented the code in hard-to-understand areas
  • Followed the code style guidelines of this project
  • Reviewed that the files changed in GitHub’s UI reflect my intended changes
  • Confirmed the pipeline checks are not failing

Review Checklist:

  • Tested locally that all Acceptance Criteria or Expected Outcomes are satisfied
  • Confirmed that changes follow the code style guidelines of this project

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86

Copy link
Copy Markdown
Contributor Author

FYI @cgero-eth, this is basically ready for review, but I'll leave the PR in draft state until I make sure the interface completely fits the requirements on the App side.

@arabot-1

arabot-1 commented Aug 27, 2025

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment: View Here

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Comment thread .changeset/young-flies-think.md Outdated
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
milosh86 requested a review from cgero-eth August 27, 2025 14:41
Signed-off-by: Milos Dzepina <milos@aragon.org>
Comment thread src/core/components/dropdown/dropdownItem/dropdownItem.tsx
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86 milosh86 changed the title WIP: feat(APP-4058): Implement ProposalActionSimulationStructure component feat(APP-4058): Implement ProposalActionSimulationStructure component Aug 29, 2025
@milosh86 milosh86 changed the title feat(APP-4058): Implement ProposalActionSimulationStructure component feat(APP-4058): Implement ActionSimulation component Aug 29, 2025
@milosh86
milosh86 marked this pull request as ready for review August 29, 2025 11:20
Copilot AI review requested due to automatic review settings August 29, 2025 11:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the ActionSimulation component for displaying simulation status and controls for blockchain proposal actions, and enhances the dropdown component to support form submission.

  • Adds a new ActionSimulation component with simulation status, timestamp display, and action controls
  • Updates dropdown component to accept variant prop and support submit button functionality
  • Adds comprehensive test coverage and documentation for the new component

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/modules/components/index.ts Exports the new action module
src/modules/components/action/index.ts Exports actionSimulation component
src/modules/components/action/actionSimulation/index.ts Re-exports ActionSimulation component
src/modules/components/action/actionSimulation/actionSimulation.tsx Main ActionSimulation component implementation
src/modules/components/action/actionSimulation/actionSimulation.test.tsx Test suite for ActionSimulation component
src/modules/components/action/actionSimulation/actionSimulation.stories.tsx Storybook stories for ActionSimulation component
src/modules/assets/copy/modulesCopy.ts Adds copy text for actionSimulation component
src/core/components/dropdown/dropdownItem/dropdownItem.tsx Adds formId prop to support submit button functionality
src/core/components/dropdown/dropdownItem/dropdownItem.stories.tsx Adds story for submit button functionality
src/core/components/dropdown/dropdownContainer/dropdownContainer.tsx Adds variant prop to dropdown container
src/core/components/dropdown/dropdownContainer/dropdownContainer.stories.tsx Adds story for variant prop
.changeset/young-flies-think.md Changeset file documenting the minor version change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

milosh86 and others added 2 commits August 29, 2025 14:42
Comment thread src/modules/assets/copy/modulesCopy.ts Outdated
Comment thread src/modules/components/action/actionSimulation/actionSimulation.tsx Outdated
Comment thread src/modules/components/action/actionSimulation/actionSimulation.test.tsx Outdated
Comment thread src/modules/components/action/actionSimulation/actionSimulation.test.tsx Outdated
Comment thread src/modules/components/action/actionSimulation/actionSimulation.test.tsx Outdated
Comment thread src/modules/components/action/actionSimulation/actionSimulation.test.tsx Outdated
Comment thread src/core/components/dropdown/dropdownItem/dropdownItem.tsx Outdated
@cgero-eth

cgero-eth commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

The status text should be text-base on md
Screenshot 2025-08-29 at 15 27 45

Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
@milosh86
milosh86 requested a review from cgero-eth August 29, 2025 13:59
cgero-eth
cgero-eth previously approved these changes Aug 29, 2025
Comment thread src/modules/components/action/actionSimulation/index.ts Outdated
Signed-off-by: Milos Dzepina <milos@aragon.org>
@cgero-eth
cgero-eth merged commit f97d58b into main Aug 29, 2025
9 of 10 checks passed
@cgero-eth
cgero-eth deleted the APP-4058-tenderly branch August 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants