feat(APP-4058): Implement ActionSimulation component - #572
Merged
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Contributor
Author
|
FYI @cgero-eth, this is basically ready for review, but I'll leave the PR in draft state until I make sure the interface completely fits the requirements on the App side. |
Contributor
|
🚀 Preview Deployment: View Here |
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
cgero-eth
reviewed
Aug 27, 2025
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
commented
Aug 28, 2025
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
milosh86
marked this pull request as ready for review
August 29, 2025 11:20
There was a problem hiding this comment.
Pull Request Overview
This PR implements the ActionSimulation component for displaying simulation status and controls for blockchain proposal actions, and enhances the dropdown component to support form submission.
- Adds a new
ActionSimulationcomponent with simulation status, timestamp display, and action controls - Updates dropdown component to accept
variantprop and support submit button functionality - Adds comprehensive test coverage and documentation for the new component
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/modules/components/index.ts |
Exports the new action module |
src/modules/components/action/index.ts |
Exports actionSimulation component |
src/modules/components/action/actionSimulation/index.ts |
Re-exports ActionSimulation component |
src/modules/components/action/actionSimulation/actionSimulation.tsx |
Main ActionSimulation component implementation |
src/modules/components/action/actionSimulation/actionSimulation.test.tsx |
Test suite for ActionSimulation component |
src/modules/components/action/actionSimulation/actionSimulation.stories.tsx |
Storybook stories for ActionSimulation component |
src/modules/assets/copy/modulesCopy.ts |
Adds copy text for actionSimulation component |
src/core/components/dropdown/dropdownItem/dropdownItem.tsx |
Adds formId prop to support submit button functionality |
src/core/components/dropdown/dropdownItem/dropdownItem.stories.tsx |
Adds story for submit button functionality |
src/core/components/dropdown/dropdownContainer/dropdownContainer.tsx |
Adds variant prop to dropdown container |
src/core/components/dropdown/dropdownContainer/dropdownContainer.stories.tsx |
Adds story for variant prop |
.changeset/young-flies-think.md |
Changeset file documenting the minor version change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Milos Dzepina <milos@aragon.org>
cgero-eth
reviewed
Aug 29, 2025
Contributor
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
cgero-eth
previously approved these changes
Aug 29, 2025
Signed-off-by: Milos Dzepina <milos@aragon.org>
cgero-eth
approved these changes
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
ActionSimulationcomponent.variantfrom and to allow rendering items as submit buttons.Task: APP-4058
Type of change
Developer Checklist:
Review Checklist: