feat: Add hideValue flag to TransactionDataListItem - #583
Merged
Conversation
Signed-off-by: Milos Dzepina <milos@aragon.org>
Signed-off-by: Milos Dzepina <milos@aragon.org>
There was a problem hiding this comment.
Pull Request Overview
This PR adds a hideValue prop to the TransactionDataListItem component that allows hiding the fiat value (USD price) display while still showing the token amount.
- Added optional
hideValueboolean prop to control fiat value visibility - Updated component structure to conditionally render the USD price span
- Added comprehensive test coverage and Storybook examples
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| transactionDataListItemStructure.tsx | Added hideValue prop handling and conditional rendering of USD price |
| transactionDataListItemStructure.test.tsx | Added test case to verify USD price is hidden when hideValue is true |
| transactionDataListItemStructure.stories.tsx | Added new story examples including HideValue variant |
| transactionDataListItemStructure.api.ts | Added hideValue prop to TypeScript interface with documentation |
| nine-moles-start.md | Added changeset entry for the new feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
🚀 Preview Deployment: View Here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
hideValueprop toTransactionDataListItemto hide the fiat value.Task: APP-4534
Type of change
Developer Checklist:
Review Checklist: