[RD-1865] Gauge continuous distributions #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the allocator strategy to distribute tokens to gauges based on votes received rather than to voters based on voting power. The same proportional allocation logic is used but applied to gauge vote counts instead of voter powers.
The change adds proper validation to prevent setting distributions for past epochs that have no snapshot, while allowing updates to snapshotted epochs.
The strategy now relies on external claim tracking rather than storing claim data internally
The commit modifies the allocation strategy to use live data from the gauge voter contract for current epoch calculations, while still using snapshots for past epochs.
The tests analyze gas usage patterns for claims across different epochs and distributions, helping measure and optimize performance.
The commit adds a sum to optimize gas costs for calculating past epochs' distributions. Key changes: - Implement sum processing when setting epoch distributions - Optimize getClaimeableAmount by using sum values for past epochs - Add tests for sum functionality and gas optimization
xavikh
changed the title
brickpop
reviewed
Aug 29, 2025
Comment on lines
+58
to
+59
| if (msg.sender != owner() && msg.sender != address(dao())) { | ||
| revert IAllocatorStrategy.OnlyDAOAllowed(msg.sender); |
There was a problem hiding this comment.
owner() or dao() doesn't match OnlyDAOAllowed()
| super.initialize(_strategyTypeId, _dao, _plugin, _auxData); | ||
|
|
||
| IGaugeVoterSnapshotter _snapshotter = abi.decode(_auxData, (IGaugeVoterSnapshotter)); | ||
| if (address(_snapshotter) == address(0)) revert InvalidSnapshotter(); |
There was a problem hiding this comment.
Additional checks like code.size or supportsInterface() might help
Comment on lines
+89
to
+101
| function getInitializationEncodingTypes() external pure override returns (string memory types) { | ||
| return "address"; // IGaugeVoterSnapshotter | ||
| } | ||
|
|
||
| /// @inheritdoc IAllocatorStrategy | ||
| function getCreationEncodingTypes() external pure override returns (string memory types) { | ||
| return "uint256,uint256"; // startEpoch, endEpoch | ||
| } | ||
|
|
||
| /// @inheritdoc IAllocatorStrategy | ||
| function getClaimEncodingTypes() external pure override returns (string memory types) { | ||
| return ""; // No auxData needed for claims since we accumulate all epochs | ||
| } |
There was a problem hiding this comment.
As recommended earlier, I would provide a single source of truth (i.e. encodeInitializeParams(), decodeInitializeParams(), encodeNewEncodingTypes, ...) rather than shipping ABI getters that the UI must handle on its own and which may add friction/mismatches
| GaugeDistributionCampaign storage campaign = campaigns[_campaignId]; | ||
|
|
||
| // Validate campaign exists | ||
| _validateCampaignExists(_campaignId); |
| uint256 startFrom = _getNextUnprocessedEpoch(campaign); | ||
|
|
||
| // Only calculate epochs not yet processed | ||
| for (uint256 epoch = startFrom; epoch <= endEpoch;) { |
There was a problem hiding this comment.
Unbound loops may lead to gas limit issues in the future.
- Why are we looping if we mainly care about
epoch == currentEpoch? - What is
snapshotter.isEpochSnapshotted()actually doing?
| /// @notice Validates that a past epoch has a snapshot | ||
| /// @param _epochId Epoch to validate | ||
| /// @param _currentEpoch Current epoch | ||
| function _validatePastEpochHasSnapshot(uint256 _epochId, uint256 _currentEpoch) internal view { |
Comment on lines
+488
to
+491
| _setEpochDistribution(campaign, _epochId, _amount, currentEpoch); | ||
| } | ||
|
|
||
| function _setEpochDistribution( |
There was a problem hiding this comment.
Set epoch distribution, what is the "distribution" being set?
Consider adding natspec comments that explain what this function is about
| /// @title GaugeVoterSnapshotter | ||
| /// @notice Contract that captures and stores historical gauge voting data | ||
| /// @dev Stores snapshots of gauge votes and total voting power for each epoch | ||
| contract GaugeVoterSnapshotter is IGaugeVoterSnapshotter, DaoAuthorizableUpgradeable { |
There was a problem hiding this comment.
Why using DaoAuthorizableUpgradeable if there is no auth() guard or dao() getter?
| ERC165Upgradeable | ||
| { | ||
| /// @notice The ID of the permission required to manage encoder configurations | ||
| bytes32 public constant ENCODER_MANAGER_PERMISSION_ID = keccak256("ENCODER_MANAGER_PERMISSION"); |
| ERC165Upgradeable | ||
| { | ||
| /// @notice The ID of the permission required to manage strategy configurations | ||
| bytes32 public constant STRATEGY_MANAGER_PERMISSION_ID = keccak256("STRATEGY_MANAGER_PERMISSION"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files to focus on to review: