params are always accessed with promise in app-dir#87
Merged
aralroca merged 3 commits intoaralroca:mainfrom Jul 12, 2025
Merged
params are always accessed with promise in app-dir#87aralroca merged 3 commits intoaralroca:mainfrom
aralroca merged 3 commits intoaralroca:mainfrom
Conversation
This check doesn't work as expected and cause a issues with next-js 14.
i.e
```
export default async function __Next_Translate_new__197f0ebfc2e__(props) {
const detectedLang = await props.params?.lang ?? props.searchParams?.lang
^
if (detectedLang === 'favicon.ico') return <RootLayout {...props} />
```
Owner
|
@timotew can you run |
Contributor
Author
|
Fixed now, thanks for the reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check doesn't work as expected and cause a issues with next-js 14. i.e
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x ] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
Always access param using promise
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?