-
Notifications
You must be signed in to change notification settings - Fork 26
Fix re-export detection for Turbopack compatibility #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aralroca
merged 2 commits into
main
from
fix-reexport-detection-turbopack-13189860664831108325
Feb 28, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import { parseCode, hasExportName } from '../src/utils' | ||
|
|
||
| // Related with https://github.com/aralroca/next-translate-plugin/issues/91 | ||
| describe('repro issue', () => { | ||
| it('should detect re-exported getStaticProps', () => { | ||
| const code = ` | ||
| export { getStaticProps } from './data' | ||
| export default function Page() { | ||
| return <h1>Page</h1> | ||
| } | ||
| ` | ||
| const pagePkg = parseCode('jsx', code) | ||
| expect(hasExportName(pagePkg, 'getStaticProps')).toBe(true) | ||
| }) | ||
|
|
||
| it('should detect re-exported getServerSideProps', () => { | ||
| const code = ` | ||
| export { getServerSideProps as GSSP } from './data' | ||
| export default function Page() { | ||
| return <h1>Page</h1> | ||
| } | ||
| ` | ||
| const pagePkg = parseCode('jsx', code) | ||
| // Actually hasExportName checks for the name it is exported AS. | ||
| expect(hasExportName(pagePkg, 'GSSP')).toBe(true) | ||
| }) | ||
|
|
||
| it('should detect re-exported all from another file', () => { | ||
| const code = ` | ||
| export * from './data' | ||
| export default function Page() { | ||
| return <h1>Page</h1> | ||
| } | ||
| ` | ||
| const pagePkg = parseCode('jsx', code) | ||
| // If ./data is not resolved, this will fail | ||
| expect(hasExportName(pagePkg, 'getServerSideProps')).toBe(true) | ||
| }) | ||
|
|
||
| it('should return false for non-data-fetching methods when export * is present', () => { | ||
| const code = ` | ||
| export * from './data' | ||
| export default function Page() { | ||
| return <h1>Page</h1> | ||
| } | ||
| ` | ||
| const pagePkg = parseCode('jsx', code) | ||
| expect(hasExportName(pagePkg, 'someOtherExport')).toBe(false) | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the ID of the issue: #91