[REF] Support SPM25 for t1-volume
#1542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adam-Ismaili-92
requested changes
Oct 17, 2025
There was a problem hiding this comment.
Thanks @AliceJoubert for your work !
The tests were mainly focused on non-regression ones.
The tests have only been conducted on Linux, third party softwares (MATLAB, MCR) still need to be properly downloaded on Mac for the remaining tests to be conducted.
On Linux :
- SPM12 works well (throwing an error recommending SPM25 installation)
- SPM12 Standalone works well (throwing an error recommending SPM25 installation)
- SPM25 sends assertion errors or loads indefinitely
- SPM25 Standalone sends an error probably linked to an installation or compatibility issue with MCR :
”OSError: This docstring was not generated by Nipype!”
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the informations of the
t1-volumepipeline to recommend SPM25 usage. Technically SPM12 still work on it but it is easier to download SPM25 nowadays.Some code from Nipype was adapted to drop SPM8 and allow NewSegment usage for SPM25.
Todo :
To test on :