Skip to content

Conversation

@Adam-Ismaili-92
Copy link
Contributor

Closes #1557

@Adam-Ismaili-92 Adam-Ismaili-92 self-assigned this Oct 29, 2025
@Adam-Ismaili-92 Adam-Ismaili-92 added enhancement New feature or request doc Documentation (wiki, source code, etc.) labels Oct 29, 2025
Copy link
Contributor

@AliceJoubert AliceJoubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small addition (feel free to change as you prefer the names) but otherwise it's good, thanks for the work ! @Adam-Ismaili-92



## Checklist
- [ ] Coding style respected
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To detail a little : type hints, '_' to write variable names, private or public functions, docstrings

- [ ] Functionally tested on Mac OS
- [ ] Functionally tested on Linux
- [ ] Documentation updated (if applicable)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [ ] Instantiations tests
- [ ] Non-regression/functional tests on MacOS / Linux
- [ ] CI data modified if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Documentation (wiki, source code, etc.) enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DOC] A template needs to be added to PRs

2 participants