Skip to content

Add Covariate Model #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: v2
Choose a base branch
from
Draft

Add Covariate Model #438

wants to merge 8 commits into from

Conversation

@GabrielleCasimiro
Copy link
Contributor

Add Covariate Model Structure

This PR introduces the full implementation of the covariate model, following the standard architecture:

  • CovariateTimeReparametrizedModel inherits from McmcSaemCompatibleModel
  • CovariateRiemanianManifoldModel inherits from CovariateTimeReparametrizedModel
  • CovariateLogisticModel inherits from:
    • CovariateLogisticInitializationMixin
    • CovariateRiemanianManifoldModel

Notes

  • The model runs, and the population parameters g and v0 are properly updated during the iterations.
  • Known issue: the tau parameters are not updated during training yet. This behavior needs further investigation.

lea-aguilhon and others added 4 commits July 4, 2025 15:49
@lea-aguilhon @caglayantuna
Add docstrings data/factory.py (aramis-lab#432)
f3fa3d0 
* add docstrings

* changes

* Apply suggestions from code review

Co-authored-by: caglayantuna <[email protected]>

---------

Co-authored-by: caglayantuna <[email protected]>
@lea-aguilhon
Add docstrings mcmc_saem_compatible.py (aramis-lab#434)
ddb3eb2 
* changes

* modifications after suggestions
Add covariate model structure
a365c76
Comment save_plot_patient_reconstructions
668600d
@caglayantuna
Copy link
Contributor

Hello @GabrielleCasimiro , can you check if phi_tau is updated during the iterations? The issue should be solved here. Am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caglayantuna caglayantuna Awaiting requested review from caglayantuna

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GabrielleCasimiro @caglayantuna @lea-aguilhon