Changed APPIRATER_APP_ID #define to static NSString #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that you can replace the definition with a snippet of code (say, pulling it from a configuration file for different targets). The previous code only worked with a bare integer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried replacing the integer app ID with a code snippet (we have like 40 different targets and are pulling the app ID out of a configuration file), and found that the code was expecting a bare integer. So I deleted the -stringWithFormat: call, and changed the #define to the @"12355" format.
I can see arguments both ways, but this parallels the other #defines (some of which are code snippets) a bit better.
Thanks for this project, by the way. It's well-written and a real time-saver!