Skip to content

Reviewbranch-testingcodereview #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aravind-dd-11556 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Reviewbranch-testingcodereview #2

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
758a4b8
Checking review - string to int
Aravindargutus Sep 26, 2025
0aed8fe
changes fixed
Aravindargutus Sep 26, 2025
99c9f20
constructor change
Aravindargutus Sep 26, 2025
16cf933
message
Aravindargutus Sep 26, 2025
81bc3b0
message
Aravindargutus Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion functions/poll_service_java/Service.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void runner(HttpServletRequest request, HttpServletResponse response) thr
responseData = getMyVotesOrCompletedPolls(user_id, page);
responseData.remove("pollMap");

} else if (url.equals("/MyPolls") && method.equals(POST)) {
} else if (url.equals("/MyPoll") && method.equals(POST)) {
Copy link
Copy Markdown

@pantoaibot pantoaibot bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CRITICAL_BUG] The endpoint change from '/MyPolls' to '/MyPoll' could break backward compatibility. Verify that this update is intentional and that all clients are updated accordingly.

Copy link
Copy Markdown

@pantoaibot pantoaibot bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CRITICAL_BUG] The endpoint change from '/MyPolls' to '/MyPoll' could break backward compatibility. Verify that this update is intentional and that all clients are updated accordingly.

Copy link
Copy Markdown

@pantoaibot pantoaibot bot Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[VALIDATION] Validate that the request parameters (e.g., 'user_id' and 'page') exist and are non-null before calling toString() or parsing them to prevent potential NullPointerExceptions.

String user_id = requestParameters.get("user_id") != null ? requestParameters.get("user_id").toString() : null;
if (user_id == null) {
    // handle missing user_id, e.g., throw exception or return error response
}
Object pageObj = requestParameters.get("page");
Integer page = null;
if (pageObj != null) {
    page = Integer.parseInt(pageObj.toString());
} else {
    // handle missing page, e.g., throw exception or return error response
}

Copy link
Copy Markdown

@pantoaibot pantoaibot bot Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[REFACTORING] The endpoint URL has been changed from '/MyPolls' to '/MyPoll' (line 72). Ensure that this update is consistently reflected in client integrations and documentation.


ServletInputStream requestBody = request.getInputStream();
JSONParser jsonParser = new JSONParser();
Expand Down