Skip to content

Attachments: Enhancements , strategy specific to certain LLMs#1733

Merged
dartpain merged 28 commits intoarc53:mainfrom
ManishMadan2882:main
Apr 14, 2025
Merged

Attachments: Enhancements , strategy specific to certain LLMs#1733
dartpain merged 28 commits intoarc53:mainfrom
ManishMadan2882:main

Conversation

@ManishMadan2882
Copy link
Copy Markdown
Collaborator

@ManishMadan2882 ManishMadan2882 commented Apr 6, 2025

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    - Files are stored as <settings.UPLOAD_FOLDER>/<user>/attachments/ObjectId/filename.ext
    - Show warning(!) on failing uploads to the frontend
    - Add functionality to remove files(x)
    - OpenAI specific approach to send files(pdfs/images for now)
    {'role': 'user', 'content': [{'type': 'text', 'text': 'Hi'}, {'type': 'file', 'file': {'file_id': 'file-XYZ'}}]}
  • Why was this change needed? (You can also link to an open issue here)
    - Continuation of the Attachments feature

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2025

@ManishMadan2882 is attempting to deploy a commit to the Arc53 Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 7.20339% with 219 lines in your changes missing coverage. Please review.

Project coverage is 28.74%. Comparing base (55bd90f) to head (ad610d2).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
application/llm/openai.py 8.51% 86 Missing ⚠️
application/llm/google_ai.py 8.23% 78 Missing ⚠️
application/agents/llm_handler.py 2.94% 33 Missing ⚠️
application/worker.py 0.00% 14 Missing ⚠️
application/agents/classic_agent.py 0.00% 3 Missing ⚠️
application/api/user/routes.py 0.00% 3 Missing ⚠️
application/api/answer/routes.py 0.00% 1 Missing ⚠️
application/llm/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1733      +/-   ##
==========================================
- Coverage   29.13%   28.74%   -0.39%     
==========================================
  Files          85       85              
  Lines        5069     5162      +93     
==========================================
+ Hits         1477     1484       +7     
- Misses       3592     3678      +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2025 10:55pm

@dartpain dartpain merged commit 5e1aaf5 into arc53:main Apr 14, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚀 Feature: Attachment source doc

3 participants