Fix: Add fallback image for broken agent avatars #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added onError handler to AgentCard.tsx to fallback to Robot icon - Added onError handler and alt attribute to SharedAgentCard.tsx - Fixes issue arc53#1983 where broken image URLs showed broken image icon - Now displays default Robot avatar when image fails to load
|
@nouroweiss is attempting to deploy a commit to the Arc53 Team on Vercel. A member of the Team first needs to authorize it. |
| <div className="flex w-full items-center gap-1 px-1"> | ||
| <img | ||
| src={agent.image && agent.image.trim() !== '' ? agent.image : Robot} | ||
| // src={agent.image && agent.image.trim() !== '' ? agent.image : Robot} |
There was a problem hiding this comment.
agent.image should not be replaced; only the onError attribute could be incorporated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1983
What kind of change does this PR introduce?
Bug fix
Why was this change needed?
When agent image URLs are broken or unavailable, a broken image icon is displayed instead of a fallback, reducing the user experience quality. This PR ensures that when an image fails to load, users see the default Robot avatar instead of a broken image placeholder.
Changes made
Testing
I verified the logic of the onError handler through code review and created a simple test to validate the fallback behavior. Full integration testing was not possible due to local environment setup issues with Docker, but the onError pattern is a standard React approach for handling image load failures.