RTL Support - #45
Draft
moshekv wants to merge 2 commits into
Draft
Conversation
Author
|
Added a simple RTL support. There is buttons to choose which align: And text is align automatically! Will improve the system in future time. |
moshekv
marked this pull request as draft
March 27, 2023 23:34
arch1t3cht
force-pushed
the
feature
branch
18 times, most recently
from
April 21, 2023 14:22
1d8e74e to
26a5f00
Compare
arch1t3cht
force-pushed
the
feature
branch
6 times, most recently
from
May 19, 2023 18:39
f2a2973 to
5e51c59
Compare
arch1t3cht
force-pushed
the
feature
branch
5 times, most recently
from
May 29, 2023 12:52
a13233a to
dba4f49
Compare
arch1t3cht
force-pushed
the
feature
branch
2 times, most recently
from
October 17, 2023 16:31
d8c611d to
4ebdc2b
Compare
arch1t3cht
force-pushed
the
feature
branch
2 times, most recently
from
April 3, 2024 16:30
b54f508 to
a455e07
Compare
arch1t3cht
force-pushed
the
feature
branch
3 times, most recently
from
May 21, 2024 12:02
914ad0e to
0e44a34
Compare
moi15moi
reviewed
Aug 15, 2024
|
|
||
| bool IsCharRTL(wxChar c) { | ||
| // only hebrew for now | ||
| return (((wxChar)0x5d0) <= c) && (c <= ((wxChar)0x5ea)); |
There was a problem hiding this comment.
I haven't tested, but this should be better and support all the RTL character.
Suggested change
| return (((wxChar)0x5d0) <= c) && (c <= ((wxChar)0x5ea)); | |
| bool IsCharRTL(wxChar character) { | |
| hb_unicode_funcs_t* unicode_funcs = hb_unicode_funcs_get_default(); | |
| hb_script_t script = hb_unicode_script(unicode_funcs, character); | |
| return hb_script_get_horizontal_direction(script) == HB_DIRECTION_RTL; | |
| } |
Author
|
I would like to insert this feature, @arch1t3cht are you okay with this, or you want me to find a better solution to handle RTL? I now have time and want to invest for a good solution. |
mojie126
added a commit
to mojie126/Aegisub
that referenced
this pull request
Feb 28, 2026
…h1t3cht#28 - 修复TypesettingTools#173: \fn0字体重置，在libass/VSFilter中等同于\fn，重置为样式默认字体 - 修复TypesettingTools#45: 分辨率设置UB，'设为视频分辨率'不再调用ResampleResolution - 修复TypesettingTools#118: SRT时间精度，厘秒转换从四舍五入改为截断，匹配VSFilter/libass - 修复TypesettingTools#28: 字体收集器性能，PrintUsage行号批量拼接输出
mojie126
added a commit
to mojie126/Aegisub
that referenced
this pull request
Mar 19, 2026
…h1t3cht#28 - 修复TypesettingTools#173: \fn0字体重置，在libass/VSFilter中等同于\fn，重置为样式默认字体 - 修复TypesettingTools#45: 分辨率设置UB，'设为视频分辨率'不再调用ResampleResolution - 修复TypesettingTools#118: SRT时间精度，厘秒转换从四舍五入改为截断，匹配VSFilter/libass - 修复TypesettingTools#28: 字体收集器性能，PrintUsage行号批量拼接输出
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.