feat: fix emoji truncation issue about Ellipsis#324
Merged
Conversation
tangshumin666
changed the title
Ellipsis
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an emoji truncation issue by updating the logic in the Ellipsis component to remove orphan high-surrogate characters that may result in incomplete emoji rendering.
- Adjusts text trimming to target incomplete surrogate pairs.
- Enhances comment clarity regarding emoji handling.
Comments suppressed due to low confidence (1)
packages/arcodesign/components/ellipsis/components/js-ellipsis.tsx:71
- Consider updating the comment above this line to clarify that the regex removes only orphaned high-surrogate characters (indicative of incomplete emoji) rather than implying it removes any emoji character.
currentText = currentText.replace(/[�-�]+$/, '');
adaex
approved these changes
May 15, 2025
TinaPeach
pushed a commit
that referenced
this pull request
May 15, 2025
ziqisia
pushed a commit
that referenced
this pull request
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.