Issue/736 add more warnings as errors#1052
Open
MartinHock wants to merge 5 commits into
Open
Conversation
MartinHock
force-pushed
the
issue/736-add-more-warnings-as-errors
branch
from
July 20, 2026 14:48
dd2b716 to
97f2598
Compare
Enable latest-All analysis, promote code analysis warnings to errors, and resolve the resulting analyzer findings with targeted suppressions where framework and test conventions require them.
MartinHock
force-pushed
the
issue/736-add-more-warnings-as-errors
branch
from
July 20, 2026 15:29
97f2598 to
6651e94
Compare
Contributor
Author
|
The current cross-platform build succeeds on Ubuntu, Windows, and macOS. However, merging is still blocked because the repository requires a status check named I found that this required check appears to come from the former jobs: The current workflow reports the matrix jobs successfully, but no longer reports a check named exactly Could a maintainer please update the required status check in the branch protection rules, or add an appropriate aggregate |
Added a detailed comment in Directory.Build.props explaining the exclusion of NU1903 from errors. The comment clarifies that the warning is due to a known vulnerable transitive dependency (SQLItePCLRaw.lib.e_sqlit3) required by Microsoft.Data.Sqlite.Core 7.0.0/7.0.1 for .NET 10.0 support, and provides guidance for removing the exclusion once the issue is resolved. No functional changes were made.
Updated the comment explaining the exclusion of the NU1903 warning for the vulnerable transitive dependency SQLitePCLRaw.lib.e_sqlite3. The revised comment clarifies that the warning will remain visible but will not fail the build while the issue is being addressed (see issue ardalis#1066 and PR ardalis#1067). It also notes to remove the exclusion once the dependency is updated or the PR is merged. No functional code changes were made.
Added #pragma warning disable CA1716 and explanatory comments to GetContributorHandler.cs and GetContributorQuery.cs to suppress the analyzer warning about the 'Get' namespace segment conflicting with reserved keywords. Comments clarify that renaming is a breaking change tracked separately. Warnings are restored after the namespace declaration.
Added a comment explaining CA1716 is triggered by the "Get" namespace segment due to reserved keyword conflicts in some .NET languages. Included a pragma directive to disable the warning, preserving the public namespace. Referenced issue ardalis#1065 for a permanent fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removed the warnings that were appearing after latest-all was added to Directoy.build.props
and analysis was switched on