Skip to content

fix: remove outdated js-yaml patch breaking postinstall on Node 26 - #4076

Merged
ardatan merged 3 commits into
dependabot/npm_and_yarn/js-yaml-5.2.3from
copilot/fix-integration-node-26-job
Aug 7, 2026
Merged

fix: remove outdated js-yaml patch breaking postinstall on Node 26#4076
ardatan merged 3 commits into
dependabot/npm_and_yarn/js-yaml-5.2.3from
copilot/fix-integration-node-26-job

Conversation

Copilot AI commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

patch-package fails during postinstall because patches/js-yaml+4.2.0.patch targets index.js from js-yaml 4.2.0, but js-yaml 5.2.3 (now installed) ships dist/js-yaml.cjs.js — the patch target no longer exists.

Changes

  • Delete patches/js-yaml+4.2.0.patch — the patch added safeLoad/safeLoadAll/safeDump aliases for backward compat with js-yaml v3 callers; no code in the repo or its dependency tree uses those symbols, so the patch is obsolete.

Copilot AI changed the title fix: remove outdated js-yaml+4.2.0.patch that causes postinstall failure fix: remove outdated js-yaml patch breaking postinstall on Node 26 Aug 7, 2026
Copilot AI requested a review from ardatan August 7, 2026 14:27
@ardatan
ardatan force-pushed the copilot/fix-integration-node-26-job branch from d2fd0c1 to 7308314 Compare August 7, 2026 14:28
Copilot AI and others added 2 commits August 7, 2026 18:28
Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
…e-bundler

Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
@ardatan
ardatan force-pushed the copilot/fix-integration-node-26-job branch from f185d6f to fec0027 Compare August 7, 2026 15:28
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ Benchmark Results

     ✓ no_errors{server:node-http,mode:no-schema}
     ✓ expected_result{server:node-http,mode:no-schema}
     ✓ no_errors{server:node-http,mode:json-schema}
     ✓ expected_result{server:node-http,mode:json-schema}
     ✓ no_errors{server:uWebSockets,mode:no-schema}
     ✓ expected_result{server:uWebSockets,mode:no-schema}
     ✓ no_errors{server:uWebSockets,mode:json-schema}
     ✓ expected_result{server:uWebSockets,mode:json-schema}

     checks......................................: 100.00% ✓ 884034      ✗ 0     
     data_received...............................: 80 MB   669 kB/s
     data_sent...................................: 56 MB   468 kB/s
     http_req_blocked............................: avg=1.45µs   min=661ns    med=1.27µs   max=947.71µs p(90)=1.75µs   p(95)=2.29µs  
     http_req_connecting.........................: avg=1ns      min=0s       med=0s       max=142.63µs p(90)=0s       p(95)=0s      
     http_req_duration...........................: avg=194.21µs min=125.73µs med=184.96µs max=9.59ms   p(90)=212.62µs p(95)=221.39µs
       { expected_response:true }................: avg=194.21µs min=125.73µs med=184.96µs max=9.59ms   p(90)=212.62µs p(95)=221.39µs
     ✓ { server:node-http,mode:json-schema }.....: avg=205.07µs min=146.77µs med=195.14µs max=9.59ms   p(90)=221.99µs p(95)=229.61µs
     ✓ { server:node-http,mode:no-schema }.......: avg=196.82µs min=132.46µs med=184.86µs max=9.36ms   p(90)=212.95µs p(95)=223.15µs
     ✓ { server:uWebSockets,mode:json-schema }...: avg=191.45µs min=133.15µs med=184.31µs max=8.34ms   p(90)=208.43µs p(95)=215.24µs
     ✓ { server:uWebSockets,mode:no-schema }.....: avg=184.39µs min=125.73µs med=177.02µs max=9.22ms   p(90)=201.15µs p(95)=208.47µs
     http_req_failed.............................: 0.00%   ✓ 0           ✗ 442017
     http_req_receiving..........................: avg=24.59µs  min=9.93µs   med=23.64µs  max=3.05ms   p(90)=31.16µs  p(95)=33.03µs 
     http_req_sending............................: avg=8.34µs   min=4.35µs   med=7.73µs   max=1.99ms   p(90)=11.38µs  p(95)=12.55µs 
     http_req_tls_handshaking....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting............................: avg=161.27µs min=98.14µs  med=152.15µs max=9.54ms   p(90)=177.31µs p(95)=184.96µs
     http_reqs...................................: 442017  3683.439916/s
     iteration_duration..........................: avg=266.6µs  min=187.89µs med=256.56µs max=9.73ms   p(90)=289.54µs p(95)=300.42µs
     iterations..................................: 442017  3683.439916/s
     vus.........................................: 1       min=1         max=1   
     vus_max.....................................: 2       min=2         max=2   

…for gray-matter

Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-4076.fets-3ku.pages.dev

@ardatan
ardatan marked this pull request as ready for review August 7, 2026 16:02
Copilot AI lite review requested due to automatic review settings August 7, 2026 16:02
@ardatan
ardatan merged commit 37392d9 into master Aug 7, 2026
22 checks passed
@ardatan
ardatan deleted the copilot/fix-integration-node-26-job branch August 7, 2026 16:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix patch-package failures during postinstall after upgrading js-yaml to 5.2.3, by removing the outdated 4.2.0-targeted patch and introducing an updated patch targeting the new distribution files.

Changes:

  • Added a new patch-package patch for js-yaml@5.2.3 that modifies dist/js-yaml.cjs.js and dist/js-yaml.mjs.
  • Removed the obsolete patches/js-yaml+4.2.0.patch which no longer matches the installed js-yaml file layout.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
patches/js-yaml+5.2.3.patch New patch targeting js-yaml@5.2.3 dist outputs, reintroducing compatibility exports and adding an ESM export change.
patches/js-yaml+4.2.0.patch Removed outdated patch that no longer applies to the installed js-yaml version.
Suppressed comments (1)

patches/js-yaml+5.2.3.patch:26

  • In the ESM patch (dist/js-yaml.mjs), this adds a new default export instead of providing the stated backwards-compat safeLoad/safeLoadAll/safeDump aliases. If we keep the patch for compatibility, it should export the safe* aliases here too (adding a default export changes the module surface area and doesn’t help callers looking for safeLoad).
+export default { load, loadAll, dump };

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +11 to +14
+//# sourceMappingURL=js-yaml.cjs.js.map
+exports.safeLoad = exports.load;
+exports.safeLoadAll = exports.loadAll;
+exports.safeDump = exports.dump;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants