fix: remove outdated js-yaml patch breaking postinstall on Node 26 - #4076
Merged
ardatan merged 3 commits intoAug 7, 2026
Merged
Conversation
Copilot
AI
changed the title
fix: remove outdated js-yaml+4.2.0.patch that causes postinstall failure
fix: remove outdated js-yaml patch breaking postinstall on Node 26
Aug 7, 2026
Copilot created this pull request from a session on behalf of
ardatan
August 7, 2026 14:27
View session
ardatan
force-pushed
the
copilot/fix-integration-node-26-job
branch
from
August 7, 2026 14:28
d2fd0c1 to
7308314
Compare
Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
…e-bundler Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
ardatan
force-pushed
the
copilot/fix-integration-node-26-job
branch
from
August 7, 2026 15:28
f185d6f to
fec0027
Compare
Contributor
✅ Benchmark Results |
…for gray-matter Co-authored-by: ardatan <20847995+ardatan@users.noreply.github.com>
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-4076.fets-3ku.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR aims to fix patch-package failures during postinstall after upgrading js-yaml to 5.2.3, by removing the outdated 4.2.0-targeted patch and introducing an updated patch targeting the new distribution files.
Changes:
- Added a new
patch-packagepatch forjs-yaml@5.2.3that modifiesdist/js-yaml.cjs.jsanddist/js-yaml.mjs. - Removed the obsolete
patches/js-yaml+4.2.0.patchwhich no longer matches the installedjs-yamlfile layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| patches/js-yaml+5.2.3.patch | New patch targeting js-yaml@5.2.3 dist outputs, reintroducing compatibility exports and adding an ESM export change. |
| patches/js-yaml+4.2.0.patch | Removed outdated patch that no longer applies to the installed js-yaml version. |
Suppressed comments (1)
patches/js-yaml+5.2.3.patch:26
- In the ESM patch (
dist/js-yaml.mjs), this adds a new default export instead of providing the stated backwards-compatsafeLoad/safeLoadAll/safeDumpaliases. If we keep the patch for compatibility, it should export the safe* aliases here too (adding a default export changes the module surface area and doesn’t help callers looking forsafeLoad).
+export default { load, loadAll, dump };
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
+14
| +//# sourceMappingURL=js-yaml.cjs.js.map | ||
| +exports.safeLoad = exports.load; | ||
| +exports.safeLoadAll = exports.loadAll; | ||
| +exports.safeDump = exports.dump; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
patch-packagefails duringpostinstallbecausepatches/js-yaml+4.2.0.patchtargetsindex.jsfrom js-yaml 4.2.0, but js-yaml 5.2.3 (now installed) shipsdist/js-yaml.cjs.js— the patch target no longer exists.Changes
patches/js-yaml+4.2.0.patch— the patch addedsafeLoad/safeLoadAll/safeDumpaliases for backward compat with js-yaml v3 callers; no code in the repo or its dependency tree uses those symbols, so the patch is obsolete.