Skip to content

fix: pin Swagger UI dark theme CSS to a commit SHA - #4083

Merged
ardatan merged 1 commit into
masterfrom
fix/pin-swagger-dark-theme
Aug 7, 2026
Merged

fix: pin Swagger UI dark theme CSS to a commit SHA#4083
ardatan merged 1 commit into
masterfrom
fix/pin-swagger-dark-theme

Conversation

@ardatan

@ardatan ardatan commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Pin the dark-theme stylesheet to jsDelivr gh/...@868ea5da… (immutable commit)
  • Keep the existing SRI hash (content unchanged)
  • Clarify the earlier changeset wording

Follow-up for Copilot review comments on #4082.

Test plan

  • Fetched the commit-pinned URL and verified sha384 matches the HTML attribute
  • CI green

Address review feedback on #4082: jsDelivr GitHub assets need an immutable @sha so SRI stays valid if upstream default branch moves.
Copilot AI lite review requested due to automatic review settings August 7, 2026 16:30
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ardatan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ac51e39b-39cc-46dc-935d-97e0ecdfabdb

📥 Commits

Reviewing files that changed from the base of the PR and between 0ba3386 and 3b16524.

📒 Files selected for processing (3)
  • .changeset/pin-swagger-dark-theme.md
  • .changeset/swagger-ui-sri.md
  • packages/fets/src/swagger-ui.html

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ardatan ardatan changed the title fix(fets): pin Swagger UI dark theme CSS to a commit SHA fix: pin Swagger UI dark theme CSS to a commit SHA Aug 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Pins the Swagger UI dark-theme stylesheet URL to an immutable jsDelivr GitHub commit SHA while keeping the existing Subresource Integrity hash, and updates/clarifies changeset messaging to reflect the current asset-loading approach.

Changes:

  • Pin swagger_ui_dark.min.css on jsDelivr to gh/...@868ea5da... (commit SHA) while retaining the existing sha384 SRI attribute.
  • Clarify the existing changeset to focus on swagger-ui-dist@5.11.0 + SRI loading via <link>/<script>.
  • Add a new changeset documenting the commit-pinned dark-theme CSS rationale.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/fets/src/swagger-ui.html Pins the dark-theme CSS jsDelivr URL to a specific commit SHA (immutable) while keeping SRI metadata.
.changeset/swagger-ui-sri.md Updates wording to align with the current Swagger UI asset pinning + SRI approach.
.changeset/pin-swagger-dark-theme.md Adds a changeset explicitly documenting the dark-theme CSS commit pinning with SRI.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
fets 0.8.9-alpha-20260807163154-3b1652429b7ece812cca7998479ca991e67b30fa npm ↗︎ unpkg ↗︎

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

💻 Website Preview

The latest changes are available as preview in: https://pr-4083.fets-3ku.pages.dev

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ Benchmark Results

     ✓ no_errors{server:node-http,mode:no-schema}
     ✓ expected_result{server:node-http,mode:no-schema}
     ✓ no_errors{server:node-http,mode:json-schema}
     ✓ expected_result{server:node-http,mode:json-schema}
     ✓ no_errors{server:uWebSockets,mode:no-schema}
     ✓ expected_result{server:uWebSockets,mode:no-schema}
     ✓ no_errors{server:uWebSockets,mode:json-schema}
     ✓ expected_result{server:uWebSockets,mode:json-schema}

     checks......................................: 100.00% ✓ 877738     ✗ 0     
     data_received...............................: 80 MB   665 kB/s
     data_sent...................................: 56 MB   464 kB/s
     http_req_blocked............................: avg=1.44µs   min=711ns    med=1.25µs   max=279.98µs p(90)=1.76µs   p(95)=2.36µs  
     http_req_connecting.........................: avg=1ns      min=0s       med=0s       max=161.64µs p(90)=0s       p(95)=0s      
     http_req_duration...........................: avg=195.48µs min=120.3µs  med=185.69µs max=9.63ms   p(90)=213.17µs p(95)=221.8µs 
       { expected_response:true }................: avg=195.48µs min=120.3µs  med=185.69µs max=9.63ms   p(90)=213.17µs p(95)=221.8µs 
     ✓ { server:node-http,mode:json-schema }.....: avg=203.98µs min=140.75µs med=193.57µs max=8.89ms   p(90)=220.55µs p(95)=228.53µs
     ✓ { server:node-http,mode:no-schema }.......: avg=198.18µs min=136.45µs med=185.43µs max=9.24ms   p(90)=213.82µs p(95)=223.94µs
     ✓ { server:uWebSockets,mode:json-schema }...: avg=193.99µs min=131.26µs med=185.96µs max=9.63ms   p(90)=210.64µs p(95)=218.2µs 
     ✓ { server:uWebSockets,mode:no-schema }.....: avg=186.37µs min=120.3µs  med=178.35µs max=9.33ms   p(90)=202.99µs p(95)=210.7µs 
     http_req_failed.............................: 0.00%   ✓ 0          ✗ 438869
     http_req_receiving..........................: avg=24.77µs  min=10.28µs  med=23.73µs  max=8.36ms   p(90)=31.3µs   p(95)=33.32µs 
     http_req_sending............................: avg=8.32µs   min=4.35µs   med=7.75µs   max=2.95ms   p(90)=11.35µs  p(95)=12.75µs 
     http_req_tls_handshaking....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting............................: avg=162.38µs min=93.18µs  med=152.68µs max=9.29ms   p(90)=177.67µs p(95)=185.3µs 
     http_reqs...................................: 438869  3657.20363/s
     iteration_duration..........................: avg=268.56µs min=185.27µs med=257.78µs max=9.75ms   p(90)=291.14µs p(95)=302.42µs
     iterations..................................: 438869  3657.20363/s
     vus.........................................: 1       min=1        max=1   
     vus_max.....................................: 2       min=2        max=2   

@ardatan
ardatan merged commit d7dc0ce into master Aug 7, 2026
23 of 24 checks passed
@ardatan
ardatan deleted the fix/pin-swagger-dark-theme branch August 7, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants