Skip to content

Update Babel v8 #3455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ardatan wants to merge 13 commits into from
Closed

Update Babel v8 #3455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f167025
Update Babel v8
ardatan Jul 2, 2026
e523a0a
Seperate Node 18
ardatan Jul 2, 2026
820ded7
Babel v7
ardatan Jul 2, 2026
40d1782
Wrong script
ardatan Jul 2, 2026
a7f096b
:facepalm: typo in the script file name
ardatan Jul 2, 2026
add04be
Add missing require
ardatan Jul 2, 2026
4303ee0
Fix path of package.json
ardatan Jul 2, 2026
a5236b9
Fix package.json destination path
ardatan Jul 2, 2026
825531f
Remove unnecessary uWS import
ardatan Jul 2, 2026
d293e8e
httpbin usage fix
ardatan Jul 2, 2026
e0c610d
Patch jest leak detector to fix Leak detection on later Node
ardatan Jul 2, 2026
8b19a6c
Leak and regular tests are parallel
ardatan Jul 2, 2026
41cd09e
Fix Leak detector patch
ardatan Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ jobs:
- name: Upgrade npm
if: ${{ matrix.node-version != 18 }}
run: npm install -g npm@latest
- if: ${{ matrix.node-version == 18 }}
name: Setup Babel v7 for Node 18
run: |
npm run setup-babel-v7
npm install
- name: Cache npm and Jest
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
with:
Expand All @@ -97,18 +102,19 @@ jobs:
}}
restore-keys: |
${{ runner.os }}-${{ matrix.node-version }}-npm-jest-
- name: Unit Tests
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4
with:
timeout_minutes: 10
max_attempts: 5
command: npm run test --ci
- name: Leak Tests
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4
with:
timeout_minutes: 10
max_attempts: 5
command: npm run test:leaks --ci
- parallel:
- name: Unit Tests
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4
with:
timeout_minutes: 10
max_attempts: 5
command: npm run test --ci
- name: Leak Tests
uses: nick-fields/retry@ad984534de44a9489a53aefd81eb77f87c70dc60 # v4
with:
timeout_minutes: 10
max_attempts: 5
command: npm run test:leaks --ci

unit-bun:
name: unit / bun
Expand Down
4 changes: 2 additions & 2 deletions babel.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {
'@babel/preset-typescript',
],
plugins: [
'@babel/plugin-proposal-class-properties',
'@babel/plugin-proposal-explicit-resource-management',
'@babel/plugin-transform-class-properties',
'@babel/plugin-transform-explicit-resource-management',
Comment on lines +7 to +8

@coderabbitai coderabbitai Bot Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check installed jest/babel-jest versions and their Babel 8 support
fd package.json -d 1 --exec cat {} \; 2>/dev/null | jq '.devDependencies | {jest, "babel-jest": ."babel-jest"}'
rg -n '"jest"|"babel-jest"' package.json

Repository: ardatan/whatwg-node

Length of output: 262

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo '## package.json relevant deps'
python3 - <<'PY'
import json
from pathlib import Path
p = json.loads(Path('package.json').read_text())
for section in ['dependencies', 'devDependencies', 'peerDependencies', 'optionalDependencies']:
    deps = p.get(section, {})
    picks = {k: deps[k] for k in deps if k.startswith('`@babel/`') or k in ('jest', 'babel-jest')}
    if picks:
        print(section, json.dumps(picks, indent=2, sort_keys=True))
PY

echo
echo '## babel.config.js'
cat -n babel.config.js

echo
echo '## jest.config.js'
cat -n jest.config.js

Repository: ardatan/whatwg-node

Length of output: 2527

🌐 Web query:

babel-jest 30.4.1 Babel 8 support @babel/core 8 compatibility

💡 Result:

Babel 8 support is not fully integrated into babel-jest version 30.4.1 [1][2]. While babel-jest 30.4.1 (released May 8, 2026) included initial preparations for Babel 8, such as updating internal plugin configurations to use 'denylist' instead of 'blacklist' [3], it does not provide comprehensive support for Babel 8 [4]. The Jest project officially introduced Babel 8 support in later releases [5][6]. Following the official release of Babel 8.0.0 on June 16, 2026 [7], the Jest repository initiated updates to its dependencies to align with the new major version [6]. Users requiring full Babel 8 compatibility should ensure they are using a more recent version of Jest/babel-jest than 30.4.1, as the project has been actively updating its dependency tree to support the @babel/core 8.x ecosystem [6].

Citations:

Upgrade babel-jest for Babel 8

package.json pins @babel/core@8.0.1, but babel-jest@30.4.1 still needs a Babel 8-capable release. Update Jest/babel-jest together or the Jest transform path can fail at runtime.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@babel.config.js` around lines 7 - 8, The Jest transform setup is using a
Babel 8-incompatible babel-jest version while babel.config.js already targets
Babel 8, so update the Jest/babel-jest dependency pair together. Check the Jest
transform path and the relevant package.json entries for babel-jest and Jest,
and bump them to matching Babel 8-capable releases so the test runner can load
the Babel config at runtime.

],
};
Loading
Loading