Fix Chromecast casting with Redirect profile and auto refresh stream on session end - #119
Merged
Merged
Conversation
Author
|
It would make sense to introduce a function such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues (#118) with Chromecast functionality:
Issue 1: Redirect profile doesn't properly construct stream URL for Chromecast
Changes:
loadMedia()incast.jsto detect when a raw stream URL (from Redirect profile) is passedguideState.settings.activeStreamProfileIdto determine if the current profile is a redirect profileIssue 2: No stream reload when Chromecast session ends
Changes:
forceRefreshStreamfromplayer.jsincast.jshandleSessionStateChange(), whenSESSION_ENDEDoccurs, the function now callsforceRefreshStream()