Increase MQTT buffer size on STM32H7#416
Open
manchoz wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Increase MQTT buffer size on STM32H7#416manchoz wants to merge 1 commit intoarduino-libraries:masterfrom
manchoz wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 27 27
Lines 1221 1221
=======================================
Hits 1160 1160
Misses 61 61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 345c34a
Click for full report table
Click for full report CSV |
pennam
requested changes
Feb 19, 2024
Collaborator
pennam
left a comment
There was a problem hiding this comment.
@manchoz do you mind adding a configuration define in https://github.com/arduino-libraries/ArduinoIoTCloud/blob/master/src/AIoTC_Config.h file ?
something like #define AIOT_CONFIG_MQTT_TX_BUFFER_SIZE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing MQTT buffer size on STM32H7-based board allows use cases such as using large
Stringvalues to carry payloads to 3rd platforms.