Conversation
048f452 to
adf3dcf
Compare
|
@kittaakos is this pending a design decision? Thanks
|
@davegarthsimpson, yes. |
|
@kittaakos the icon looks great. wdyt? |
Yes, IDE2 needs the icons if the feature is required. Please see the PR description with the electron restrictions on the icon.
I am not in the loop, I do not even know when does the next release happen. |
Ref: #1826 Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
Dispatching the icon based on IDE2's theme is not the best idea. The OS native menu is still dark, although the IDE2's theme is light. Please decide, @91volt. Thanks! In-action: cloud_icon_ide_theme.mp4 |
Another approach could be using the |
|
Akos Kitta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Depends on #1833
Motivation
As asked for in #1826, IDE2 would like to show an icon for cloud sketches in File > Open Recent.
This is just the infrastructure and an example of how IDE2 can render a custom image for a menu item. The images are missing from the PR. Here is the documentation of supported native image formats. If IDE2 wants to dispatch images on the selected theme, I am happy to update the PR.
Source of my example cloud image: https://imagensemoldes.com.br/wp-content/uploads/2020/04/%C3%8Dcone-Computador-Nuvem-PNG.png
Change description
nativeImage.directories.data/RemoteSketchbook.Other information
Ref: #1826
Reviewer checklist