Skip to content

Fix wrong resistor band in simple audio player tutorial #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix wrong resistor band in simple audio player tutorial #1172

wants to merge 2 commits into from

Conversation

benrpinto
Copy link

What This PR Changes

  • Corrected a diagram in the Simple Audio Player tutorial
  • Changed bands on resistor from 10k ohms to 10 ohms to match specifications in the tutorial
  • Changed image dimensions to match contribution guidelines

Contribution Guidelines

benrpinto added 2 commits July 12, 2023 12:12
@benrpinto
Corrected diagram in Simple audio player tutorial
2a436fc 
Changed bands on resistor from 10k ohms to 10 ohms to match specifications in the tutorial
@benrpinto
Updated image to fit contribution guidelines
a1d4210
@benrpinto benrpinto changed the title Benrpinto/simple audio player tutorial Fix wrong resistor band in simple audio player tutorial Jul 12, 2023
@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community maker labels Jul 12, 2023
V205Arduino
V205Arduino reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@V205Arduino V205Arduino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right.
Looking at diagram.

V205Arduino
V205Arduino approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@V205Arduino V205Arduino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Will the longer length cause problems?

@benrpinto
Copy link
Author

Judging by the simple-audio-player.md preview, it doesn't appear to cause any problems.
The line (line 71) where the file is used doesn't do any fancy formatting that would need to be changed, it reads:
![LM386 mounting on breadboard](assets/LM386_AudioZero_bb.png)

Is there a way to properly preview the website? The Previewing Changes section at the bottom of the main readme mentions

The link to the preview will appear in the comments of the PR. This also works with Draft PRs, but not for PRs created from a fork.

But I created this PR from a fork, so there's no link here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@V205Arduino V205Arduino V205Arduino approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update maker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benrpinto @V205Arduino @jhansson-ard