Skip to content

Add some details and fixes to LoRaWAN tutorial #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add some details and fixes to LoRaWAN tutorial #1227

wants to merge 2 commits into from

Conversation

ewa
Copy link

@ewa ewa commented Jul 25, 2023

Add notes about Adaptive Data Rate (ADR) process in LoRaWAN

  • Corrected "bandwidth" defined as "network throughput" to "bandwidth" defined as "amount of spectrum used by a signal" because that's kind that's actually being talked about and controlled in this context.
  • Added more information about ADR parameters.

Contribution Guidelines

ewa added 2 commits July 25, 2023 10:42
@ewa
Clarify LinkADRReq parameters
ccbc944 
The original definition was for the wrong kind of "bandwidth," and while I was making that change I got sucked into adding a little more explanation, and including the Redundancy parameter
@ewa
LoRa: Added a little description and citation
1f37fc3 
Explained a little more about how data rate control works
@CLAassistant
Copy link

CLAassistant commented Jul 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added community Bugs and fixes suggested by the community pro fix/update A small fix or update labels Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canchebagur canchebagur Awaiting requested review from canchebagur

@TaddyHC TaddyHC Awaiting requested review from TaddyHC

At least 1 approving review is required to merge this pull request.

Assignees

@canchebagur canchebagur

@TaddyHC TaddyHC

Labels
community Bugs and fixes suggested by the community fix/update A small fix or update pro
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ewa @CLAassistant @canchebagur @jhansson-ard @TaddyHC