Update WiFiRTC.md regarding the timezone #1632
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correction to add the GMT info orginial code: print2digits(rtc.getHours() + GMT); That line is wrong because only adds hours but doesn't contemplate if that sum affects the change of date (adding or subtracting) The correct way is to add/substract 3600 seconds per hour of GMT to the value got from epoch
|
|
jhansson-ard
added
fix/update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Changes
Correction on the code to handle the GMT info.
The orginial code adds the GMT variable at the moment of printing the hour:
print2digits(rtc.getHours() + GMT);
But the concept is wrong because only operates hours but doesn't contemplate if that operation affects the change of date (adding or subtracting). The correct way is to add/substract 3600 seconds per hour of GMT to the value got from epoch:
rtc.setEpoch(epoch+ GMT*3600); //Add the time zone to the epoch
Contribution Guidelines