Skip to content

Update msr3-controlling-dc-motor.md with correct duty range #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kerbinite
Copy link

@kerbinite kerbinite commented Mar 18, 2024

The tutorial describes the accepted range of values for indicating the work duty of the motors as 0-100. In testing, it is determined that the actual range of values is 0-255. A value of 100 is actually less than half of the maximum allowed work duty.

What This PR Changes

  • Only changes the listed maximum work duty from 100 to 255.

Contribution Guidelines

The tutorial describes the accepted range of values for indicating the work duty of the motors as 0-100. In testing, it is determined that the actual range of values is 0-255. A value of 100 is actually less than half of the maximum allowed work duty.
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2024

CLA assistant check
All committers have signed the CLA.

@jhansson-ard jhansson-ard added fix/update A small fix or update community Bugs and fixes suggested by the community maker labels Mar 19, 2024
@jhansson-ard
Copy link
Contributor

Hello @kerbinite !

Please sign the CLA so that we can review your PR properly ⭐

Thank you for your contribution!

@kerbinite
Copy link
Author

Hi @jhansson-ard ! 👋

It seems that my commit was unable to be merged due to a missing apiToken for Cloudflare. I'm not sure what needs to be done to resolve this, but I'm very appreciative of your attention here, and all your work maintaining this! 👍

I'm running an Arduino course for high school students, and I want to ensure that they aren't confused by the documentation. Thank you so much!!!

@jhansson-ard
Copy link
Contributor

Yes, sorry about that. The Cloudflare Pages action is an unfortunate name, it is really just creating a preview of the page - which in this case is no issue. All the important checks have gone through ⭐

I will tag the relevant reviewers and let them have a look!

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Bugs and fixes suggested by the community fix/update A small fix or update maker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants