Skip to content

Removing validation on main #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removing validation on main #1907

wants to merge 1 commit into from

Conversation

lukdog
Copy link
Member

@lukdog lukdog commented Apr 29, 2024

What This PR Changes

We 're spending a lot of minutes of GH action also slowing down other jobs for content validation on main.
It is not really important because the validation is already performed on PRs, and the content can not be merged if the validation in PR fails.

Contribution Guidelines

@lukdog lukdog requested a review from jhansson-ard April 29, 2024 15:27
@jhansson-ard
Copy link
Contributor

@lukdog does this mean that the validations won't run on a "push to production" action but we'll still have them on PRs?

@jhansson-ard jhansson-ard added arduino Bugs and fixes added by the Arduino Team infrastructure Fixes and updates to the infrastructure of the repo labels Apr 30, 2024
@lukdog
Copy link
Member Author

lukdog commented Apr 30, 2024

@lukdog does this mean that the validations won't run on a "push to production" action but we'll still have them on PRs?

At the moment the Validation was not running on deploy to production, but only after a merge to main branch.
I think it is not really needed because the PRs are already checked, and no-one is checking the status of this validation after merge.

But maybe, a good idea can be to apply this, but add the validation on deploy, blocking non valid content.
WDYT?

@jhansson-ard
Copy link
Contributor

Yes, then we can remove this - like you said, the PRs should already be checked. If the validation breaks there we should not be able to push to main :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arduino Bugs and fixes added by the Arduino Team infrastructure Fixes and updates to the infrastructure of the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants