Skip to content

Fix options rendering in APTConfigLine breaking its output#17

Open
mickael-carl wants to merge 1 commit intoarduino:masterfrom
mickael-carl:mcarl/fix-options-missing-space
Open

Fix options rendering in APTConfigLine breaking its output#17
mickael-carl wants to merge 1 commit intoarduino:masterfrom
mickael-carl:mcarl/fix-options-missing-space

Conversation

@mickael-carl
Copy link
Copy Markdown

Without that added space, the line generated is actually invalid. Take for instance Docker's apt repository: parsing its apt config line deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable will yield a well-formed repository. However, re-generating the line with APTConfigLine from that Repository will yield deb [signed-by=/etc/apt/keyrings/docker.asc]https://download.docker.com/linux/debian bookworm stable (note the missing space). This will result in errors such as:

Error: Malformed entry 1 in list file /etc/apt/sources.list.d/stable.list ([option] not assignment)
Error: The list of sources could not be read.

Without that added space, the line generated is actually invalid. Take
for instance Docker's apt repository: parsing its apt config line
`deb [signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/debian bookworm stable`
will yield a well-formed repository. However, re-generating the line
with APTConfigLine from that Repository will yield
`deb [signed-by=/etc/apt/keyrings/docker.asc]https://download.docker.com/linux/debian bookworm stable`
(note the missing space). This will result in errors such as:
```
Error: Malformed entry 1 in list file /etc/apt/sources.list.d/stable.list ([option] not assignment)
Error: The list of sources could not be read.
```
@per1234 per1234 added the bug label Nov 3, 2025
@mickael-carl
Copy link
Copy Markdown
Author

mickael-carl commented Nov 3, 2025

@per1234 given that this is a bug, would you be open to review this PR? I suspect the other enhancements I've opened can wait but without this fix I think any repository addition with an option actually breaks.
Moving forward, I'm happy to step in and help maintain this repository further if you're looking for additional maintainers.

@per1234
Copy link
Copy Markdown

per1234 commented Nov 3, 2025

Hi @mickael-carl. Thanks so much for your contributions, and for your offer to assist in the maintenance!

I only act in a janitorial role in this project, without any involvement in the development. So unfortunately I am not able to provide code reviews, merge PRs, or make decisions regarding project management.

@mickael-carl
Copy link
Copy Markdown
Author

@per1234 thanks for the quick response! Would you happen to know who I could contact for assistance?

@mickael-carl
Copy link
Copy Markdown
Author

@cmaglie maybe?

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@arduino arduino deleted a comment from CLAassistant Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants