Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exception in twill command if database is not configured #2750

Open
wants to merge 4 commits into
base: 3.x
Choose a base branch
from
Open

fix: exception in twill command if database is not configured #2750

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2aa664c
fix: exception in twill command if database is not configured
Tofandel Mar 21, 2025
3fb8141
Ask to create the migrations
Tofandel Mar 21, 2025
daab266
Ask to create the migrations
Tofandel Mar 21, 2025
adeec81
Update confirmation message
ifox Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 37 additions & 7 deletions src/Commands/Traits/HandlesPotentialBreakingChangesWarnings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace A17\Twill\Commands\Traits;

use Illuminate\Database\QueryException;
use Illuminate\Support\Facades\Schema;

/* @mixin \Illuminate\Console\Command */
Expand All @@ -13,17 +14,46 @@ public function warnAboutNewPositionColumns(): void
return;
}

$mediablesHasPosition = Schema::hasColumn(config('twill.mediables_table', 'twill_mediables'), 'position');
$fileablesHasPosition = Schema::hasColumn(config('twill.fileables_table', 'twill_fileables'), 'position');
try {
$mediablesHasPosition = Schema::hasColumn(config('twill.mediables_table', 'twill_mediables'), 'position');
$fileablesHasPosition = Schema::hasColumn(config('twill.fileables_table', 'twill_fileables'), 'position');
} catch (QueryException) {
// If no database configured abort
return;
}

if ($mediablesHasPosition && $fileablesHasPosition) {
return;
}

$this->warn('⚠️ Twill 3.5.0 introduced 2 new database migrations to fix a bug with the medias and files fields position management, make sure to add them to your project.');
$this->warn("\nAdd position field to the twill_mediables table:");
$this->info("🔗 https://github.com/area17/twill/blob/3.5.0/migrations/default/2020_02_09_000015_add_position_to_twill_default_mediables_table.php");
$this->warn("\nAdd position field to the twill_fileables table:");
$this->info("🔗 https://github.com/area17/twill/blob/3.5.0/migrations/default/2020_02_09_000016_add_position_to_twill_default_fileables_table.php");
$this->warn("⚠️ Twill 3.5.0 introduced 2 new database migrations to fix a bug with the medias and files fields position management, make sure to add them to your project.\n");

if ($this->confirm('Would you like to add the migration to your project?')) {
if (!$mediablesHasPosition) {
copy(
__DIR__ . '/../../../migrations/default/2020_02_09_000015_add_position_to_twill_default_mediables_table.php',
$added = database_path() . '/migrations/' . date('Y_m_d_His') . '_add_position_to_twill_default_mediables_table.php'
);
$this->info('Added migration ' . str_replace(base_path(), '', $added));
}
if (!$fileablesHasPosition) {
copy(
__DIR__ . '/../../../migrations/default/2020_02_09_000016_add_position_to_twill_default_fileables_table.php',
$added = database_path() . '/migrations/' . date('Y_m_d_His') . '_add_position_to_twill_default_fileables_table.php'
);
$this->info('Added migration ' . str_replace(base_path(), '', $added));
}
$this->newLine();
$this->info("Don't forget to run <warning>php artisan migrate</warning>");
} else {
$this->info("You can find the migrations source there:");
if (!$mediablesHasPosition) {
$this->info("🔗 https://raw.githubusercontent.com/area17/twill/refs/tags/3.5.0/migrations/default/2020_02_09_000015_add_position_to_twill_default_mediables_table.php");
}
if (!$fileablesHasPosition) {
$this->info("🔗 https://raw.githubusercontent.com/area17/twill/refs/tags/3.5.0/migrations/default/2020_02_09_000016_add_position_to_twill_default_fileables_table.php");
}
}
$this->info('');
}
}
Loading