Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add ppu settings #1849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ZengGengSen
Copy link
Contributor

  • split the emulator settings
  • add ppu options

- split the emulator settings
- add ppu options
@LukeUsher
Copy link
Member

We don't usually provide toggles for accuracy settings unless they have performance impact; are there hardware revisions where these issues do not occur? If so, implementing multiple PPU revisions like the SNES core does may be a better approach, if not, I'm not sure this is something that ares would or should take, but I am open to opinions.

@FitzRoyX
Copy link
Contributor

Some info first: the recently reported Akumajou "bug" first appeared in v142 when the PPU glitch emulation was added. if you enable "PPU first-write scroll glitch" in Mesen, you get output similar to what Ares gets.

Do all PPU revisions suffer from this bug or just some of them? I have no idea. https://www.nesdev.org/wiki/PPU_variants
But if there are, then it makes sense for it to be disabled by default the way Mesen does it.

And I agree that the settings shouldn't be here, this makes them inaccessible when a game isn't running. Would be better if they were in Configuration>Options or ini only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants