Build: miscellaneous fixups #2272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of commits recently added files to ares (ded9254, 0d9ce81, ff8bdbc,
92fe0d2, be19b58, 585e43a) but did not enumerate them in the CMake build code. This means those files would not be indexed by generated IDE projects, and could also make rebuild detection unreliable. This PR adds them.Also runs a CMake formatting pass given numerous recent changes to build code generally.
Editorial aside: Ideally both of these processes would be automated, or at least detected via linting on CI, but I have yet to discover a way to do so in a robust way that is also not more trouble than it's worth for developer workflows, so for now they are done manually.
Contributors should be aware to always add files to CMake manifests when adding new files to the project.