Fix symbolic links to files for rom loading#2359
Merged
LukeUsher merged 2 commits intoares-emulator:masterfrom Jan 8, 2026
Merged
Fix symbolic links to files for rom loading#2359LukeUsher merged 2 commits intoares-emulator:masterfrom
LukeUsher merged 2 commits intoares-emulator:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path handling in ares would always treat anything past the last trailing separator as the file name. This wasn't true in the case of a symlink pointing to a file. This will now be checked prior to path processing and the symlink will be resolved to its full path prior to processing. This results in no modifcation to existing directory/file/path handling in nall so it should be safe.
With this in place, loading a rom from a path with a symlink that involves either a symlink'ed directory or file in the path does what you would expect. This works when loading from a command line, or loading via the GUI. It should work across all operating systems, but I was unable to verify on MacOS (although I believe it should work).
Fixes: #2201