Fix loading shaders from the command line#2360
Merged
LukeUsher merged 1 commit intoares-emulator:masterfrom Jan 8, 2026
Merged
Fix loading shaders from the command line#2360LukeUsher merged 1 commit intoares-emulator:masterfrom
LukeUsher merged 1 commit intoares-emulator:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a shader was specified as a command line argument, it would result in the loadShaders() function calling itself in a continuous loop with no exit. Processing the presence of the
--shadercommand line argument will now only occur once. Additionally, the shader name stored in the settings.bml file should not include a full path, it should be relative to the shader directory, minus the slangp extension.This impacted all platforms, not just Windows (the issue was opened against Windows).
Fixes: #2141