Integrate ControllerConnector #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kronosapiens
force-pushed
the
develop
branch
from
6da55b7 to
40eb824
Compare
Contributor
Author
|
Hi @bluecco, can you take a look at this PR? |
Contributor
|
hi @kronosapiens , we have @Cussone on it (along with starknetkit pr argentlabs/starknetkit#228) |
Contributor
Author
|
Hey @Cussone, wanted to follow up on this |
Member
Hey @kronosapiens, I am on it. However, I need to make some related changes first, since we're upgrading starknet.js to the next major version. It will be done in the next few days. Sorry for making you wait this much, we were on offsite last week. |
# Conflicts: # package.json # pnpm-lock.yaml
Cussone
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue / feature description
This PR integrates the new ControllerConnector, making it easier to test future updates.
Changes
ControllerConnectortoconnectors/index.ts, automatically rendering in the modalSignMessage.tsx(closes Multi-connector compatibility issues when signing messages #41)Checklist